ungoogled-software / ungoogled-chromium-macos

macOS packaging for ungoogled-chromium

BSD 3-Clause "New" or "Revised" License

252 stars 69 forks source link

Closed Cubik65536 closed 2 months ago

Cubik65536 commented 2 months ago

No modification aside from the submodule bump is needed.

Builds and runs fine locally.

PF4Public commented 2 months ago

Is Cirrus gonna run any time soon? :D

networkException commented 2 months ago

in doubt doesn't matter

Cubik65536 commented 2 months ago

Is Cirrus gonna run any time soon? :D

From what I can tell, no :(

I am working on CI migration though.

Cubik65536 commented 2 months ago

Update:

Ninja is not very happy on x86_64, working on a fix.

Cubik65536 commented 2 months ago

Update, again:

Chromium has a ninja flag that is no longer available since an update of Ninja, arm64 wasn't impacted because brew didn't update it...

Cubik65536 commented 2 months ago

Should I try to remove that flag or try to use Ninja installed from other sources? /cc @PF4Public @networkException

networkException commented 2 months ago

Well unless chromium requires to use a custom (/ outdated) version of ninja for builds we would have to remove the flag anyways going forward

Cubik65536 commented 2 months ago

Well unless chromium requires to use a custom (/ outdated) version of ninja for builds we would have to remove the flag anyways going forward

162 up for fix this, I just removed the flag, not sure what Chromium will do for now.