ungoogled-software / ungoogled-chromium-portablelinux

Portable Linux packaging for ungoogled-chromium
96 stars 30 forks source link

Small improvement: Repository directory check before updating submodules #149

Closed luizferrbarbosa closed 10 months ago

luizferrbarbosa commented 11 months ago

Description:

This pull request introduces a small but significant improvement to the build script. It implements a directory check before executing the command to update submodules within the repository.

Changes Made:

Why this Change?

Previously, the script would unconditionally attempt to update submodules, even if the repository directory was empty. This improvement ensures that the submodule update command is only executed when there's content present, optimizing the process and avoiding unnecessary executions.

Benefits:

How to Verify:

  1. Run the build script.
  2. Observe that the submodule update command is triggered only if there's content in the repository directory.
  3. Confirm that the build process functions as expected. This change aims to streamline the build process and contribute to the overall efficiency of the repository.
clickot commented 10 months ago

@luizferrbarbosa as far as i can see your PR does not change any behavior but simply replaces the hardcoded "ungoogled-chromium" subdir with the GIT_REPO var. I'll merge it nontheless. Thank you.

luizferrbarbosa commented 10 months ago

Thank you for reviewing and merging my Pull Request!