ungoogled-software / ungoogled-chromium-windows

Windows packaging for ungoogled-chromium
BSD 3-Clause "New" or "Revised" License
991 stars 100 forks source link

Installer icon for Ungoogled-Chromium has compression artifacting #172

Closed TalhaErenY closed 1 year ago

TalhaErenY commented 1 year ago

OS/Platform

Windows

Installed

https://ungoogled-software.github.io/ungoogled-chromium-binaries/

Version

105.0.5195.102 (Official Build, ungoogled-chromium) (64 bit)

Have you tested that this is not an upstream issue or an issue with your configuration?

Description

The current installer icon is broken and has significant image compression.

How to Reproduce?

  1. Download the installer.exe
  2. Look at the file on a directory with icons enabled.

Actual behaviour

an update between 102 and 105 has broken the installer icon to a compressed version

Expected behaviour

the icon should use default windows installer iconset

Relevant log output

No response

Additional context

compressedIcon

tomasz1986 commented 1 year ago

This doesn't seem to be the official installer. The reason is that there's no "mini" installer at https://github.com/ungoogled-software/ungoogled-chromium-windows/releases, and the filename scheme itself is completely different too.

Can you re-check where exactly you've obtained the file from?

Edit:

That said, I can confirm that the (official) installer icon does look pixelated and very low quality. Below is what it looks like in Explorer in Windows 10.

image

TalhaErenY commented 1 year ago

My apologies, I downloaded from the binary woolys links. I thought they were the same but I must have moused over something else checking the link. It seems to be an issue regardless, so I think the issue is still valid. I remember it used to be fine, so if someone could check previous versions and verify when it 'broke' it would be ideal (sadly my connection is rather slow). E: I am also on windows 10, just to add.

teeminus commented 1 year ago

The installer logo is part of the chromium sources, it's an 32x32 pixel ico file.

TalhaErenY commented 1 year ago

Has it always been this way and I just misremembered then? I've managed to download v97, it is the same. It seemed odd to see a non-standart installer icon.

teeminus commented 1 year ago

It's not a standard windows installer but a custom installer (basically a self extracting archive). All sources for the installer are part of the chromium project.

TalhaErenY commented 1 year ago

Apologies for the confusion, I'll close this now as it isn't a bug.