search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.74k stars 840 forks source link

Missing critical security features #1143

Closed BullShark closed 4 years ago

BullShark commented 4 years ago

Describe the bug Configuring DoH DNS over HTTPS is missing from the Windows build of ungoogled chromium.

Patch here -> https://git.droidware.info/wchen342/ungoogled-chromium-android/src/branch/master/patches/Bromite/Add-user-setting-for-DNS-over-HTTPS-DoH-custom-URL.patch

To Reproduce Steps to reproduce the behavior:

  1. Go to chrome://flags and search dns.
  2. Click on DNS over HTTPS, and enable it.
  3. Let the browser restart after making the change. It will ask to restart. Next go to preferences.
  4. This is missing from the Windows build Version 84.0.4147.105 (Developer Build) (64-bit).

DOH settings in ungoogled chromium running on Android

signal-2020-08-19-005408 signal-2020-08-19-005414 signal-2020-08-19-005403

More info here: https://www.bromite.org/doh

https://github.com/bromite/bromite/wiki/Enabling-DNS-over-HTTPS

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

HarukaMa commented 4 years ago

From https://www.chromium.org/developers/dns-over-https, it seems this feature is still in staged rollout:

We've enabled an experiment in Chrome 83 for a fraction of our users with the following scope.

You may need to change the source code or use Inspect to manipulate the states in JS in settings page to enable this feature at this time. I guess it is controlled by "variations" and it seems UC is not affected by that but I could be totally wrong there.

Eloston commented 4 years ago

Based on @HarukaMa's info, I'll let Google roll out the feature when it's ready.