ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.75k stars 840 forks source link

Update macOS support to version 55 #129

Closed Eloston closed 7 years ago

Eloston commented 7 years ago

Enough progress has been made that work on macOS can begin. I still don't have a macOS machine, so any help here is appreciated.

9Morello commented 7 years ago

@Eloston Ok, I'll start a fresh build. I'm going to upload binaries for OS X, *buntus and the static build, so please tell me if you're already building any of those.

Eloston commented 7 years ago

@9Morello I'm not doing any builds right now so you should be good to go.

9Morello commented 7 years ago

@Eloston The master branch is not building on OS X:

1 warning generated.
[1550/24360] CXX obj/extensions/browser/api/serial/serial/serial_api.o
FAILED: obj/extensions/browser/api/serial/serial/serial_api.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/extensions/browser/api/serial/serial/serial_api.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=282487-1 -DCR_XCODE_VERSION=0731 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -Igen -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -g0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../extensions/browser/api/serial/serial_api.cc -o obj/extensions/browser/api/serial/serial/serial_api.o
warning: unknown warning option '-Wno-address-of-packed-member' [-Wunknown-warning-option]
In file included from ../../extensions/browser/api/serial/serial_api.cc:5:
../../extensions/browser/api/serial/serial_api.h:10:10: fatal error: 'device/serial/serial.mojom.h' file not found
#include "device/serial/serial.mojom.h"
Eloston commented 7 years ago

@9Morello That's weird. I didn't change anything except the widevine flag on macOS.

9Morello commented 7 years ago

@Eloston seems like running brew update and brew upgradefixed it.

Eloston commented 7 years ago

@9Morello What are you using Homebrew for? There shouldn't be any use of Homebrew except for quilt (EDIT and ninja).

9Morello commented 7 years ago

@Eloston I hadn't paid attention to the software brew upgraded, but not a single one seems related to this except chromedriver. Thinks like node, ffmpeg, harfbuzz.

Eloston commented 7 years ago

@9Morello Well it's still pretty strange since Chromium shouldn't be depending on any source code from Homebrew...

It could also be possible that there's a bug in Chromium's GN configuration so that the header file you needed is actually autogenerated but there was no explicit dependency so ninja happened to build things in the wrong order. It's hard to say without digging deeper.

9Morello commented 7 years ago

@Eloston ungoogled-chromium 55.0.2883.75-1 SHA-1: 1d334feed258866d946dc463b59bcf5c09e0b75e MD5: 6c2bd5a644bf9964c244d1d12f1276d7 Download link: https://my.mixtape.moe/dzerxu.dmg

Eitot commented 7 years ago

@9Morello: which SDK have you built against?

9Morello commented 7 years ago

@Eloston OSX 10.11's SDK.

Eloston commented 7 years ago

The macOS build has been uploaded now. Thanks @9Morello.

Eitot commented 7 years ago

@9Morello: Just FYI, 10.12 SDK seems to be working fine as well.

Eloston commented 7 years ago

@Eitot Oh nice. I'll add that to the list of supported SDKs in buildlib.