search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.78k stars 843 forks source link

Revert moron new Chromium bookmark behaviour, omnibar dropdown showing path instead of URL #2524

Open joopbraak opened 1 year ago

joopbraak commented 1 year ago

Description

Revert moron new Chromium bookmark behaviour, omnibar dropdown showing path instead of URL

Who's implementing?

The problem

Chrome starts to exhibit Firefox behaviour, implementing features that no one wants except for moron users. https://superuser.com/questions/1779323/google-chrome-bookmarked-pages-dont-show-urls-anymore-on-dropdown-just-the-b https://www.reddit.com/r/chrome/comments/137suqg/bookmark_preview_showing_location_in_folders/?rdt=33578 There was a flag to revert this: chrome://flags/#omnibox-bookmark-paths but of course google removed that.

Would it be (please, please) at all possible for ungoogled-chromium to reintroduce this flag?

Thanks in advance.

Possible solutions

Reintroduce chrome://flags/#omnibox-bookmark-paths flag, maybe even enable it by default.

Alternatives

No response

Additional context

No response

uazo commented 1 year ago

It bothers me too. if you all agree, I will take this point on board.

uazo commented 1 year ago 
diff --git a/components/omnibox/browser/titled_url_match_utils.cc b/components/omnibox/browser/titled_url_match_utils.cc
index 4b7a5e6acb..f5cefc285d 100644
--- a/components/omnibox/browser/titled_url_match_utils.cc
+++ b/components/omnibox/browser/titled_url_match_utils.cc
@@ -80,7 +80,7 @@ AutocompleteMatch TitledUrlMatchToAutocompleteMatch(
   // Otherwise, display the path, even if the input matches both or neither.
   bool show_path = titled_url_match.has_ancestor_match ||
                    titled_url_match.url_match_positions.empty();
-  match.contents = show_path ? path : formatted_url;
+  match.contents = /*show_path ? path :*/ formatted_url;
   // The path can become stale (when the bookmark is moved). So persist the URL
   // instead when creating shortcuts.
   if (show_path)

very simple patch, android and windows works, if you can test it in linux. this is the commit of the remove: https://source.chromium.org/chromium/chromium/src/+/4a9dd5ab3709d60f40beb2f801a0185ab2ba992a

joopbraak commented 1 year ago

Thanks! It would be great if this was implemented. Building Chromium is beyond my expertise at the moment, so I'm waiting patiently if somebody else can test this patch in Linux .