Update to Chromium 127.0.6533.72

This PR updates to Chromium 127.0.6533.72.

Changes:

The DOH patch has been updated for the changes in [5526034]
The pruned binaries patch had a removal for [5596349] and a new addition for [5541202]
The safebrowsing patch had changes for [5562985], and new additions for [5510834] & [5447140]
remove-unused-preferences-fields.patch had changes for [5604230], a new addition for [5594029], and a removal for [5625866]
fingerprinting-flags-client-rects-and-measuretext.patch needed the header to be readded due to [5553003]
The tabsearch flag patch had a removal for [5532843]. This is for the windows-specific section, so it would nice to have verification that still works as expected.
The sidepanel flag had a removal for [5550932]
The prepopulated-search-engines patch has a new addition to remove the starter pack entries added a while ago in [5283103]. This removes the non-functional @Gemini entry, fixes #2947
third_party/instrumented_libs has been added to the contingent paths. This path isn't needed for building and wasn't ever downloaded when using the clone script. There are files in the path that probably should have been pruned and this should also prevent that focal build file from bouncing in and out of the substitution list.

Build notes:

The rust_bindgen_root gn flag will now need to be set to a path containing a bin directory containing the program
If you are building with ninja 1.12+ you might be happy to know that they have started the process of fixing the missing dependencies: (40253918). That issue should be a good resource for anyone that encounters missing generated headers.
For this build the only one I ran into was a missing webui_name_variants.h which was resolved by including the fixes linked in (345645751). I've consolidated the changes for convenience below.

The CI container ran out of memory, so I'll look into updating this PR later today with a commit to increase that once more.

Edit: It turns out that we don't actually need to increase the memory if we remove source directory once we're finished with it.

I am getting the following error building on x64 linux with system rust and clang ninja: error: '../../third_party/rust-toolchain/bin/bindgen', needed by 'gen/third_party/crabbyavif/crabbyavif_dav1d_bindings.rs', missing and no known rule to make it

but maybe something is wrong on my end, I am not sure

You'll need to set a new gn flag, rust_bindgen_root, to the path that contains the 'bin' directory containing your rust bindgen binary.

For example I have set rust_bindgen_root="/usr" for my system.

I see, thanks for letting me know! That resolved the issue completely.

portable linux builds fine and runs at least on manjaro and current ubuntu and fedora

When building on macOS, I encountered two issues.

The path for platform specific LLVM, Node, and Rust toolchain (under src/third_party) are not empty when unpacking, so I had to manually delete what was there (which wasn't necessary before), is that the correct way to handle it? Or I am supposed to change something?

When pruning binaries, I got the following output:

+ /Users/cubik65536/ungoogled-chromium-macos/ungoogled-chromium/utils/prune_binaries.py /Users/cubik65536/ungoogled-chromium-macos/build/src /Users/cubik65536/ungoogled-chromium-macos/ungoogled-chromium/pruning.list
INFO: Removing Contingent Paths
INFO: Absent: third_party/angle/third_party/VK-GL-CTS/src/
INFO: Absent: third_party/js_code_coverage/
INFO: Absent: third_party/llvm/
INFO: Absent: third_party/rust-src/
INFO: Absent: buildtools/linux64/
INFO: Absent: buildtools/reclient/
INFO: Absent: third_party/android_rust_toolchain/
INFO: Absent: third_party/apache-linux/
INFO: Absent: third_party/checkstyle/
INFO: Absent: third_party/dawn/third_party/ninja/
INFO: Absent: third_party/dawn/tools/golang/
INFO: Absent: third_party/depot_tools/external_bin/
INFO: Absent: third_party/devtools-frontend/src/third_party/esbuild/
INFO: Absent: third_party/google-java-format/
INFO: Absent: third_party/instrumented_libs/
INFO: Absent: third_party/libei/
INFO: Absent: third_party/llvm-build-tools/
INFO: Absent: third_party/ninja/
INFO: Absent: third_party/screen-ai/
INFO: Absent: third_party/siso/
INFO: Absent: third_party/updater/chrome_linux64/
INFO: Absent: third_party/updater/chromium_linux64/
INFO: Absent: tools/luci-go/
INFO: Absent: tools/resultdb/
INFO: Absent: tools/skia_goldctl/linux/
ERROR: 76 files could not be pruned.

With no other information. What should be changed for this? If more information is needed, how am I supposed to get it?

They've been adding a lot more into the DEPS which might begin to cause small issues for anyone that links/copies paths into the source directory, this is also why we were running out of space for the checks. A similar thing happened with the sysroots a while back. I've considered adding these to the contingent paths but it's original intent was to create parity between the tarball and clones.

@Cubik65536 Since the paths you use are now included you would need to change the order in your scripts:

download and unpack the main tarball
run the pruning and domain substitution scripts on that
remove the existing directories you need under third_party
then download and extract the architecture-specific resources

@Ahrotahn The new steps works, thanks! However the build process now fails at the following step:

[28724/61527] ACTION //third_party/crabbyavif:crabbyavif_dav1d_bindings(//build/toolchain/mac:clang_arm64)
FAILED: gen/third_party/crabbyavif/crabbyavif_dav1d_bindings.rs
python3 ../../build/rust/run_bindgen.py --exe ../../third_party/rust-toolchain/bin/bindgen --header ../../third_party/crabbyavif/src/sys/dav1d-sys/wrapper.h --depfile obj/third_party/crabbyavif/crabbyavif_dav1d_bindings.d --output gen/third_party/crabbyavif/crabbyavif_dav1d_bindings.rs --libclang-path ../../third_party/rust-toolchain/lib --bindgen-flags no-doc-comments generate=functions,types,vars,methods,constructors,destructors allowlist-item=dav1d_close allowlist-item=dav1d_data_unref allowlist-item=dav1d_data_wrap allowlist-item=dav1d_default_settings allowlist-item=dav1d_error allowlist-item=dav1d_get_picture allowlist-item=dav1d_open allowlist-item=dav1d_picture_unref allowlist-item=dav1d_send_data -- -DCONFIG_LOG=0 -DHAVE_PTHREAD_GETAFFINITY_NP=1 -DHAVE_PTHREAD_SETAFFINITY_NP=1 -DDAV1D_API= -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/dav1d/libdav1d -I../../third_party/dav1d/libdav1d/include -I../../third_party/dav1d/libdav1d/include/dav1d -I../../third_party/dav1d/config/apple/arm64 -I../../third_party/dav1d/version -I../.. -Igen -I../../buildtools/third_party/libc++ -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c11 -resource-dir ../../third_party/llvm-build/Release+Asserts/lib/clang/18 -isystem ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/usr/include/ -fparse-all-comments -fvisibility=default
thread 'main' panicked at bindgen/lib.rs:622:31:
Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.dylib'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
  File "/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/../../build/rust/run_bindgen.py", line 118, in <module>
    main()
  File "/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/../../build/rust/run_bindgen.py", line 106, in main
    subprocess.check_call([args.exe, *genargs], env=env)
  File "/opt/homebrew/Cellar/python@3.12/3.12.4/Frameworks/Python.framework/Versions/3.12/lib/python3.12/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/rust-toolchain/bin/bindgen', '--no-layout-tests', '--no-doc-comments', '--generate=functions,types,vars,methods,constructors,destructors', '--allowlist-item=dav1d_close', '--allowlist-item=dav1d_data_unref', '--allowlist-item=dav1d_data_wrap', '--allowlist-item=dav1d_default_settings', '--allowlist-item=dav1d_error', '--allowlist-item=dav1d_get_picture', '--allowlist-item=dav1d_open', '--allowlist-item=dav1d_picture_unref', '--allowlist-item=dav1d_send_data', '--no-rustfmt-bindings', '--rust-target', 'nightly', '--depfile', '/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/obj/third_party/crabbyavif/tmphx67oav7crabbyavif_dav1d_bindings.d', '--output', 'gen/third_party/crabbyavif/crabbyavif_dav1d_bindings.rs', '--no-include-path-detection', '../../third_party/crabbyavif/src/sys/dav1d-sys/wrapper.h', '--', '-DCONFIG_LOG=0', '-DHAVE_PTHREAD_GETAFFINITY_NP=1', '-DHAVE_PTHREAD_SETAFFINITY_NP=1', '-DDAV1D_API=', '-DOFFICIAL_BUILD', '-D__STDC_CONSTANT_MACROS', '-D__STDC_FORMAT_MACROS', '-D_FORTIFY_SOURCE=2', '-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE', '-D__ARM_NEON__=1', '-DCR_XCODE_VERSION=1600', '-D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS', '-D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS', '-DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44', '-DTEMP_REBUILD_HACK_ASSERTION_HANDLER', '-DNDEBUG', '-DNVALGRIND', '-DDYNAMIC_ANNOTATIONS_ENABLED=0', '-I../../third_party/dav1d/libdav1d', '-I../../third_party/dav1d/libdav1d/include', '-I../../third_party/dav1d/libdav1d/include/dav1d', '-I../../third_party/dav1d/config/apple/arm64', '-I../../third_party/dav1d/version', '-I../..', '-Igen', '-I../../buildtools/third_party/libc++', '-Wall', '-Wextra', '-Wimplicit-fallthrough', '-Wextra-semi', '-Wunreachable-code-aggressive', '-Wthread-safety', '-Wunguarded-availability', '-Wno-missing-field-initializers', '-Wno-unused-parameter', '-Wno-psabi', '-Wloop-analysis', '-Wno-unneeded-internal-declaration', '-Wno-cast-function-type', '-Wno-ignored-pragma-optimize', '-Wno-deprecated-builtins', '-Wno-bitfield-constant-conversion', '-Wno-deprecated-this-capture', '-Wno-invalid-offsetof', '-Wno-vla-extension', '-Wno-thread-safety-reference-return', '-Wshadow', '-fno-delete-null-pointer-checks', '-fno-ident', '-fno-strict-aliasing', '-fstack-protector', '-fcolor-diagnostics', '-fmerge-all-constants', '-fno-sized-deallocation', '-fcrash-diagnostics-dir=../../tools/clang/crashreports', '-mllvm', '-instcombine-lower-dbg-declare=0', '-mllvm', '-split-threshold-for-reg-with-hint=0', '-ffp-contract=off', '-flto=thin', '-fsplit-lto-unit', '-mllvm', '-inlinehint-threshold=360', '-fwhole-program-vtables', '-fcomplete-member-pointers', '--target=arm64-apple-macos', '-Wno-unknown-warning-option', '-mno-outline', '-no-canonical-prefixes', '-ftrivial-auto-var-init=pattern', '-O2', '-fno-math-errno', '-fno-omit-frame-pointer', '-g0', '-isysroot', '../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk', '-mmacos-version-min=10.15', '-fvisibility=hidden', '-Wheader-hygiene', '-Wstring-conversion', '-Wtautological-overlap-compare', '-std=c11', '-resource-dir', '../../third_party/llvm-build/Release+Asserts/lib/clang/18', '-isystem', '../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/usr/include/', '-fparse-all-comments', '-fvisibility=default']' returned non-zero exit status 101.
[28725/61527] ACTION //third_party/crabbyavif:crabbyavif_libyuv_bindings(//build/toolchain/mac:clang_arm64)
FAILED: gen/third_party/crabbyavif/crabbyavif_libyuv_bindings.rs
python3 ../../build/rust/run_bindgen.py --exe ../../third_party/rust-toolchain/bin/bindgen --header ../../third_party/crabbyavif/src/sys/libyuv-sys/wrapper.h --depfile obj/third_party/crabbyavif/crabbyavif_libyuv_bindings.d --output gen/third_party/crabbyavif/crabbyavif_libyuv_bindings.rs --libclang-path ../../third_party/rust-toolchain/lib --bindgen-flags no-doc-comments generate=functions,types,vars,methods,constructors,destructors allowlist-item=ARGBAttenuate allowlist-item=ARGBUnattenuate allowlist-item=Convert16To8Plane allowlist-item=FilterMode allowlist-item=FilterMode_kFilterBilinear allowlist-item=FilterMode_kFilterBox allowlist-item=FilterMode_kFilterNone allowlist-item=HalfFloatPlane allowlist-item=I010AlphaToARGBMatrix allowlist-item=I010AlphaToARGBMatrixFilter allowlist-item=I010ToARGBMatrix allowlist-item=I010ToARGBMatrixFilter allowlist-item=I012ToARGBMatrix allowlist-item=I210AlphaToARGBMatrix allowlist-item=I210AlphaToARGBMatrixFilter allowlist-item=I210ToARGBMatrix allowlist-item=I210ToARGBMatrixFilter allowlist-item=I400ToARGBMatrix allowlist-item=I410AlphaToARGBMatrix allowlist-item=I410ToARGBMatrix allowlist-item=I420AlphaToARGBMatrix allowlist-item=I420AlphaToARGBMatrixFilter allowlist-item=I420ToARGBMatrix allowlist-item=I420ToARGBMatrixFilter allowlist-item=I420ToRGB24Matrix allowlist-item=I420ToRGB24MatrixFilter allowlist-item=I420ToRGB565Matrix allowlist-item=I420ToRGBAMatrix allowlist-item=I422AlphaToARGBMatrix allowlist-item=I422AlphaToARGBMatrixFilter allowlist-item=I422ToARGBMatrix allowlist-item=I422ToARGBMatrixFilter allowlist-item=I422ToRGB24MatrixFilter allowlist-item=I422ToRGB565Matrix allowlist-item=I422ToRGBAMatrix allowlist-item=I444AlphaToARGBMatrix allowlist-item=I444ToARGBMatrix allowlist-item=I444ToRGB24Matrix allowlist-item=ScalePlane allowlist-item=ScalePlane_12 allowlist-item=YuvConstants allowlist-item=kYuv2020Constants allowlist-item=kYuvF709Constants allowlist-item=kYuvH709Constants allowlist-item=kYuvI601Constants allowlist-item=kYuvJPEGConstants allowlist-item=kYuvV2020Constants allowlist-item=kYvu2020Constants allowlist-item=kYvuF709Constants allowlist-item=kYvuH709Constants allowlist-item=kYvuI601Constants allowlist-item=kYvuJPEGConstants allowlist-item=kYvuV2020Constants -- -DLIBYUV_DISABLE_LSX -DLIBYUV_DISABLE_LASX -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/libyuv/include -I../.. -Igen -I../../buildtools/third_party/libc++ -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c11 -resource-dir ../../third_party/llvm-build/Release+Asserts/lib/clang/18 -isystem ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/usr/include/ -fparse-all-comments -fvisibility=default
thread 'main' panicked at bindgen/lib.rs:622:31:
Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.dylib'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
  File "/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/../../build/rust/run_bindgen.py", line 118, in <module>
    main()
  File "/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/../../build/rust/run_bindgen.py", line 106, in main
    subprocess.check_call([args.exe, *genargs], env=env)
  File "/opt/homebrew/Cellar/python@3.12/3.12.4/Frameworks/Python.framework/Versions/3.12/lib/python3.12/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/rust-toolchain/bin/bindgen', '--no-layout-tests', '--no-doc-comments', '--generate=functions,types,vars,methods,constructors,destructors', '--allowlist-item=ARGBAttenuate', '--allowlist-item=ARGBUnattenuate', '--allowlist-item=Convert16To8Plane', '--allowlist-item=FilterMode', '--allowlist-item=FilterMode_kFilterBilinear', '--allowlist-item=FilterMode_kFilterBox', '--allowlist-item=FilterMode_kFilterNone', '--allowlist-item=HalfFloatPlane', '--allowlist-item=I010AlphaToARGBMatrix', '--allowlist-item=I010AlphaToARGBMatrixFilter', '--allowlist-item=I010ToARGBMatrix', '--allowlist-item=I010ToARGBMatrixFilter', '--allowlist-item=I012ToARGBMatrix', '--allowlist-item=I210AlphaToARGBMatrix', '--allowlist-item=I210AlphaToARGBMatrixFilter', '--allowlist-item=I210ToARGBMatrix', '--allowlist-item=I210ToARGBMatrixFilter', '--allowlist-item=I400ToARGBMatrix', '--allowlist-item=I410AlphaToARGBMatrix', '--allowlist-item=I410ToARGBMatrix', '--allowlist-item=I420AlphaToARGBMatrix', '--allowlist-item=I420AlphaToARGBMatrixFilter', '--allowlist-item=I420ToARGBMatrix', '--allowlist-item=I420ToARGBMatrixFilter', '--allowlist-item=I420ToRGB24Matrix', '--allowlist-item=I420ToRGB24MatrixFilter', '--allowlist-item=I420ToRGB565Matrix', '--allowlist-item=I420ToRGBAMatrix', '--allowlist-item=I422AlphaToARGBMatrix', '--allowlist-item=I422AlphaToARGBMatrixFilter', '--allowlist-item=I422ToARGBMatrix', '--allowlist-item=I422ToARGBMatrixFilter', '--allowlist-item=I422ToRGB24MatrixFilter', '--allowlist-item=I422ToRGB565Matrix', '--allowlist-item=I422ToRGBAMatrix', '--allowlist-item=I444AlphaToARGBMatrix', '--allowlist-item=I444ToARGBMatrix', '--allowlist-item=I444ToRGB24Matrix', '--allowlist-item=ScalePlane', '--allowlist-item=ScalePlane_12', '--allowlist-item=YuvConstants', '--allowlist-item=kYuv2020Constants', '--allowlist-item=kYuvF709Constants', '--allowlist-item=kYuvH709Constants', '--allowlist-item=kYuvI601Constants', '--allowlist-item=kYuvJPEGConstants', '--allowlist-item=kYuvV2020Constants', '--allowlist-item=kYvu2020Constants', '--allowlist-item=kYvuF709Constants', '--allowlist-item=kYvuH709Constants', '--allowlist-item=kYvuI601Constants', '--allowlist-item=kYvuJPEGConstants', '--allowlist-item=kYvuV2020Constants', '--no-rustfmt-bindings', '--rust-target', 'nightly', '--depfile', '/Users/cubik65536/ungoogled-chromium-macos/build/src/out/Default/obj/third_party/crabbyavif/tmpqinz2v4ccrabbyavif_libyuv_bindings.d', '--output', 'gen/third_party/crabbyavif/crabbyavif_libyuv_bindings.rs', '--no-include-path-detection', '../../third_party/crabbyavif/src/sys/libyuv-sys/wrapper.h', '--', '-DLIBYUV_DISABLE_LSX', '-DLIBYUV_DISABLE_LASX', '-DOFFICIAL_BUILD', '-D__STDC_CONSTANT_MACROS', '-D__STDC_FORMAT_MACROS', '-D_FORTIFY_SOURCE=2', '-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE', '-D__ARM_NEON__=1', '-DCR_XCODE_VERSION=1600', '-D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS', '-D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS', '-DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44', '-DTEMP_REBUILD_HACK_ASSERTION_HANDLER', '-DNDEBUG', '-DNVALGRIND', '-DDYNAMIC_ANNOTATIONS_ENABLED=0', '-I../../third_party/libyuv/include', '-I../..', '-Igen', '-I../../buildtools/third_party/libc++', '-Wall', '-Wextra', '-Wimplicit-fallthrough', '-Wextra-semi', '-Wunreachable-code-aggressive', '-Wthread-safety', '-Wunguarded-availability', '-Wno-missing-field-initializers', '-Wno-unused-parameter', '-Wno-psabi', '-Wloop-analysis', '-Wno-unneeded-internal-declaration', '-Wno-cast-function-type', '-Wno-ignored-pragma-optimize', '-Wno-deprecated-builtins', '-Wno-bitfield-constant-conversion', '-Wno-deprecated-this-capture', '-Wno-invalid-offsetof', '-Wno-vla-extension', '-Wno-thread-safety-reference-return', '-Wshadow', '-fno-delete-null-pointer-checks', '-fno-ident', '-fno-strict-aliasing', '-fstack-protector', '-fcolor-diagnostics', '-fmerge-all-constants', '-fno-sized-deallocation', '-fcrash-diagnostics-dir=../../tools/clang/crashreports', '-mllvm', '-instcombine-lower-dbg-declare=0', '-mllvm', '-split-threshold-for-reg-with-hint=0', '-ffp-contract=off', '-flto=thin', '-fsplit-lto-unit', '-mllvm', '-inlinehint-threshold=360', '-fwhole-program-vtables', '-fcomplete-member-pointers', '--target=arm64-apple-macos', '-Wno-unknown-warning-option', '-mno-outline', '-no-canonical-prefixes', '-ftrivial-auto-var-init=pattern', '-O2', '-fno-math-errno', '-fno-omit-frame-pointer', '-g0', '-isysroot', '../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk', '-mmacos-version-min=10.15', '-fvisibility=hidden', '-Wheader-hygiene', '-Wstring-conversion', '-Wtautological-overlap-compare', '-std=c11', '-resource-dir', '../../third_party/llvm-build/Release+Asserts/lib/clang/18', '-isystem', '../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/usr/include/', '-fparse-all-comments', '-fvisibility=default']' returned non-zero exit status 101.

It seems that it is related to bindgen.

At the beginning, I've also encountered the ninja: error: '../../third_party/rust-toolchain/bin/bindgen', needed by 'gen/third_party/crabbyavif/crabbyavif_dav1d_bindings.rs', missing and no known rule to make it issue, and I added a new bindgen download as shown below to add the resources needed, which resolved it.

+ [rust-bindgen]
+ version = 0.69.4
+ url = https://github.com/rust-lang/rust-bindgen/releases/download/v%(version)s/bindgen-cli-+ + aarch64-apple-darwin.tar.xz
+ download_filename = bindgen-cli-aarch64-apple-darwin.tar.xz
+ output_path = third_party/rust-bindgen
+ strip_leading_dirs = bindgen-cli-aarch64-apple-darwin

Then, the issue shown above

Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.dylib'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

came up. I tried to fix it by manually assigning a LIBCLANG_PATH environment variable to the shell environment, it didn't fix the issue. While searching LIBCLANG_PATH in Chromium Source, I realized that there are some scripts that assigns LIBCLANG_PATH, are there some steps missing from my build steps so LIBCLANG_PATH wasn't set up correctly? What shall I look for to resolve the issue?

I also ran into the problem with bindgen missing on windows. Unfortunatelly, there is no precompiled binaray available for windows. While searching the web for a solution a came across a note, that bindgen must be compiled with the local clang version (or at least a matching clang version). This could be your problem, @Cubik65536

There is a script tools\rust\build_bindgen.py which can be used to compile bindgen locally and install/copy it to third_party/rust-toolchain/bin/bindgen (or third_party/rust-toolchain/bin/bindgen.exe for windows). I needed to patch the script for it to run properly:

--- a/tools/rust/build_bindgen.py
+++ b/tools/rust/build_bindgen.py
@@ -28,8 +28,7 @@ from update import (RmTree)

 # The git hash to use.
 BINDGEN_GIT_VERSION = 'f93d5dfa6d5d7409bea584f3eab38e1fc52b8360'
-BINDGEN_GIT_REPO = ('https://chromium.googlesource.com/external/' +
-                    'github.com/rust-lang/rust-bindgen')
+BINDGEN_GIT_REPO = ('https://github.com/rust-lang/rust-bindgen')

 BINDGEN_SRC_DIR = os.path.join(THIRD_PARTY_DIR, 'rust-toolchain-intermediate',
                                'bindgen-src')
@@ -102,15 +101,8 @@ def RunCargo(cargo_args):
               f'the build_rust.py script builds rustc that is needed here.')
         sys.exit(1)

-    clang_bins_dir = os.path.join(RUST_HOST_LLVM_INSTALL_DIR, 'bin')
-    llvm_dir = RUST_HOST_LLVM_INSTALL_DIR
-
-    if not os.path.exists(os.path.join(llvm_dir, 'bin', f'llvm-config{EXE}')):
-        print(f'Missing llvm-config in {llvm_dir}. This '
-              f'script expects to be run after build_rust.py is run as '
-              f'the build_rust.py script produces the LLVM libraries that '
-              f'are needed here.')
-        sys.exit(1)
+    clang_bins_dir = os.path.join(THIRD_PARTY_DIR, 'llvm-build', 'Release+Asserts', 'bin')
+    llvm_dir = os.path.join(THIRD_PARTY_DIR, 'llvm-build', 'Release+Asserts')

     env = collections.defaultdict(str, os.environ)
     # Cargo normally stores files in $HOME. Override this.
@@ -120,7 +112,6 @@ def RunCargo(cargo_args):
     env['RUSTC'] = rustc_bin

     # Use the LLVM libs and clang compiler from the rustc build.
-    env['LLVM_CONFIG_PATH'] = os.path.join(llvm_dir, 'bin', 'llvm-config')
     if sys.platform == 'win32':
         env['LIBCLANG_PATH'] = os.path.join(llvm_dir, 'bin')
     else:
@@ -207,7 +198,7 @@ def main():
     install_dir = os.path.join(RUST_TOOLCHAIN_OUT_DIR)
     print(f'Installing bindgen to {install_dir} ...')

-    llvm_dir = RUST_HOST_LLVM_INSTALL_DIR
+    llvm_dir = os.path.join(THIRD_PARTY_DIR, 'llvm-build', 'Release+Asserts')
     shutil.copy(
         os.path.join(build_dir, RustTargetTriple(), 'release',
                      f'bindgen{EXE}'), os.path.join(install_dir, 'bin'))

This works for windows, but might need adaptions for other platforms (most likely because we have our clang toolchain extracted to third_party/llvm-build/Release+Asserts which is hardcoded in the patch now).

For now, I am waiting for the compilation to succeed - hopefully... I will report back if I encounter any other problems.

The CI container ran out of memory, so I'll look into updating this PR later today with a commit to increase that once more.

It is not a surprise, given that tarball size increases again. It is 6 Gigs now!

For now, I am waiting for the compilation to succeed - hopefully... I will report back if I encounter any other problems.

Was the compilation successful? I'm now facing some new issues and I am investigating into it...

Just to share the issue for now:

[53381/61527] CXX obj/chrome/browser/ui/views/side_panel/side_panel/companion_tab_helper.o
FAILED: obj/chrome/browser/ui/views/side_panel/side_panel/companion_tab_helper.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/views/side_panel/side_panel/companion_tab_helper.o.d -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_SLUG_DISABLE_LEGACY_DESERIALIZE -DSK_DISABLE_LEGACY_VULKAN_BACKENDSEMAPHORE -DSK_DISABLE_LEGACY_CREATE_CHARACTERIZATION -DSK_DISABLE_LEGACY_VULKAN_MUTABLE_TEXTURE_STATE -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_BUILD_FOR_MAC -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_GRAPHITE -DSK_DAWN -DLIBYUV_DISABLE_LSX -DLIBYUV_DISABLE_LASX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DON_FOCUS_PING_ENABLED -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DWEBRTC_ENABLE_AVX2 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DLOGGING_INSIDE_WEBRTC -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_USE_PERFETTO -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_ENABLE_LARGER_CAGE -DCPPGC_SLIM_WRITE_BARRIER -DFLATBUFFERS_LOCALE_INDEPENDENT=0 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/libyuv/include -I../../third_party/khronos -I../../gpu -Igen/third_party/private_membership/src -Igen/third_party/shell-encryption/src -Igen/components/policy/proto -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -I../../third_party/libaom/source/config/linux/arm64-cpu-detect -I../../v8/include -Igen/third_party/metrics_proto -I../../third_party/re2/src -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/flatbuffers/src/include -I../../third_party/flatbuffers/src/src -I../../third_party/flatbuffers/src -I../../third_party/flatbuffers/generated -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wno-constant-conversion -Wno-shorten-64-to-32 -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fvisibility-inlines-hidden -c ../../chrome/browser/ui/views/side_panel/companion/companion_tab_helper.cc -o obj/chrome/browser/ui/views/side_panel/side_panel/companion_tab_helper.o
In file included from ../../chrome/browser/ui/views/side_panel/companion/companion_tab_helper.cc:15:
In file included from ../../chrome/browser/ui/webui/side_panel/companion/companion_page_handler.h:15:
In file included from ../../chrome/browser/companion/visual_query/visual_query_classifier_host.h:14:
../../chrome/browser/companion/visual_query/visual_query_suggestions_service.h:12:10: fatal error: 'chrome/common/companion/visual_query.mojom.h' file not found
   12 | #include "chrome/common/companion/visual_query.mojom.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[53386/61527] CXX obj/chrome/browser/ui/views/side_panel/side_panel/companion_side_panel_web_view.o
FAILED: obj/chrome/browser/ui/views/side_panel/side_panel/companion_side_panel_web_view.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/views/side_panel/side_panel/companion_side_panel_web_view.o.d -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_SLUG_DISABLE_LEGACY_DESERIALIZE -DSK_DISABLE_LEGACY_VULKAN_BACKENDSEMAPHORE -DSK_DISABLE_LEGACY_CREATE_CHARACTERIZATION -DSK_DISABLE_LEGACY_VULKAN_MUTABLE_TEXTURE_STATE -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_BUILD_FOR_MAC -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_GRAPHITE -DSK_DAWN -DLIBYUV_DISABLE_LSX -DLIBYUV_DISABLE_LASX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DON_FOCUS_PING_ENABLED -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DWEBRTC_ENABLE_AVX2 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DLOGGING_INSIDE_WEBRTC -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_USE_PERFETTO -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_ENABLE_LARGER_CAGE -DCPPGC_SLIM_WRITE_BARRIER -DFLATBUFFERS_LOCALE_INDEPENDENT=0 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/libyuv/include -I../../third_party/khronos -I../../gpu -Igen/third_party/private_membership/src -Igen/third_party/shell-encryption/src -Igen/components/policy/proto -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -I../../third_party/libaom/source/config/linux/arm64-cpu-detect -I../../v8/include -Igen/third_party/metrics_proto -I../../third_party/re2/src -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/flatbuffers/src/include -I../../third_party/flatbuffers/src/src -I../../third_party/flatbuffers/src -I../../third_party/flatbuffers/generated -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wno-constant-conversion -Wno-shorten-64-to-32 -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fvisibility-inlines-hidden -c ../../chrome/browser/ui/views/side_panel/companion_side_panel_web_view.cc -o obj/chrome/browser/ui/views/side_panel/side_panel/companion_side_panel_web_view.o
In file included from ../../chrome/browser/ui/views/side_panel/companion_side_panel_web_view.cc:5:
In file included from ../../chrome/browser/ui/views/side_panel/companion_side_panel_web_view.h:10:
In file included from ../../chrome/browser/ui/views/side_panel/side_panel_web_ui_view.h:12:
../../chrome/browser/ui/webui/top_chrome/webui_contents_wrapper.h:13:10: fatal error: 'chrome/browser/ui/webui_name_variants.h' file not found
   13 | #include "chrome/browser/ui/webui_name_variants.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[53388/61527] CXX obj/chrome/browser/ui/views/side_panel/side_panel/customize_chrome_side_panel_controller.o
FAILED: obj/chrome/browser/ui/views/side_panel/side_panel/customize_chrome_side_panel_controller.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/views/side_panel/side_panel/customize_chrome_side_panel_controller.o.d -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_SLUG_DISABLE_LEGACY_DESERIALIZE -DSK_DISABLE_LEGACY_VULKAN_BACKENDSEMAPHORE -DSK_DISABLE_LEGACY_CREATE_CHARACTERIZATION -DSK_DISABLE_LEGACY_VULKAN_MUTABLE_TEXTURE_STATE -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_BUILD_FOR_MAC -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_GRAPHITE -DSK_DAWN -DLIBYUV_DISABLE_LSX -DLIBYUV_DISABLE_LASX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DON_FOCUS_PING_ENABLED -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DWEBRTC_ENABLE_AVX2 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DLOGGING_INSIDE_WEBRTC -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_USE_PERFETTO -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_ENABLE_LARGER_CAGE -DCPPGC_SLIM_WRITE_BARRIER -DFLATBUFFERS_LOCALE_INDEPENDENT=0 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/libyuv/include -I../../third_party/khronos -I../../gpu -Igen/third_party/private_membership/src -Igen/third_party/shell-encryption/src -Igen/components/policy/proto -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -I../../third_party/libaom/source/config/linux/arm64-cpu-detect -I../../v8/include -Igen/third_party/metrics_proto -I../../third_party/re2/src -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/flatbuffers/src/include -I../../third_party/flatbuffers/src/src -I../../third_party/flatbuffers/src -I../../third_party/flatbuffers/generated -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wno-constant-conversion -Wno-shorten-64-to-32 -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fvisibility-inlines-hidden -c ../../chrome/browser/ui/views/side_panel/customize_chrome/customize_chrome_side_panel_controller.cc -o obj/chrome/browser/ui/views/side_panel/side_panel/customize_chrome_side_panel_controller.o
In file included from ../../chrome/browser/ui/views/side_panel/customize_chrome/customize_chrome_side_panel_controller.cc:18:
In file included from ../../chrome/browser/ui/views/side_panel/side_panel_web_ui_view.h:12:
../../chrome/browser/ui/webui/top_chrome/webui_contents_wrapper.h:13:10: fatal error: 'chrome/browser/ui/webui_name_variants.h' file not found
   13 | #include "chrome/browser/ui/webui_name_variants.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[53389/61527] CXX obj/chrome/browser/ui/views/side_panel/side_panel/bookmarks_side_panel_coordinator.o
FAILED: obj/chrome/browser/ui/views/side_panel/side_panel/bookmarks_side_panel_coordinator.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/views/side_panel/side_panel/bookmarks_side_panel_coordinator.o.d -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1600 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=852bc6746f45add53fec19f3a29280e69e358d44 -DTEMP_REBUILD_HACK_ASSERTION_HANDLER -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_SLUG_DISABLE_LEGACY_DESERIALIZE -DSK_DISABLE_LEGACY_VULKAN_BACKENDSEMAPHORE -DSK_DISABLE_LEGACY_CREATE_CHARACTERIZATION -DSK_DISABLE_LEGACY_VULKAN_MUTABLE_TEXTURE_STATE -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_BUILD_FOR_MAC -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_GRAPHITE -DSK_DAWN -DLIBYUV_DISABLE_LSX -DLIBYUV_DISABLE_LASX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DON_FOCUS_PING_ENABLED -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DWEBRTC_ENABLE_AVX2 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DLOGGING_INSIDE_WEBRTC -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_USE_PERFETTO -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_ENABLE_LARGER_CAGE -DCPPGC_SLIM_WRITE_BARRIER -DFLATBUFFERS_LOCALE_INDEPENDENT=0 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/libyuv/include -I../../third_party/khronos -I../../gpu -Igen/third_party/private_membership/src -Igen/third_party/shell-encryption/src -Igen/components/policy/proto -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -I../../third_party/libaom/source/config/linux/arm64-cpu-detect -I../../v8/include -Igen/third_party/metrics_proto -I../../third_party/re2/src -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/flatbuffers/src/include -I../../third_party/flatbuffers/src/src -I../../third_party/flatbuffers/src -I../../third_party/flatbuffers/generated -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=arm64-apple-macos -Wno-unknown-warning-option -mno-outline -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=10.15 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wno-constant-conversion -Wno-shorten-64-to-32 -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fvisibility-inlines-hidden -c ../../chrome/browser/ui/views/side_panel/bookmarks/bookmarks_side_panel_coordinator.cc -o obj/chrome/browser/ui/views/side_panel/side_panel/bookmarks_side_panel_coordinator.o
In file included from ../../chrome/browser/ui/views/side_panel/bookmarks/bookmarks_side_panel_coordinator.cc:17:
In file included from ../../chrome/browser/ui/views/side_panel/side_panel_web_ui_view.h:12:
../../chrome/browser/ui/webui/top_chrome/webui_contents_wrapper.h:13:10: fatal error: 'chrome/browser/ui/webui_name_variants.h' file not found
   13 | #include "chrome/browser/ui/webui_name_variants.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I did not finished compiling yet. I ran into a (new) missing directx header issue (the last one we fixed by removing webnn https://github.com/ungoogled-software/ungoogled-chromium/pull/2902#issuecomment-2156014965) so I downloaded the directx headers and reverted the core/ungoogled-chromium/build-without-webnn.patch to check if we can now live without it.

Unfortunatelly, my build machine ran out of memory over night and I had to salvage more RAM from an other machine just now before continuing the build process. So far, there are like 15k operations/files left.

Yeah I've been worried about how much the build process for Chromium continues to balloon in size, memory requirements, and dependencies.

@teeminus If it's more DirectML stuff I can check if there were new inclusions elsewhere. They had a section on one of the stats pages that imported the headers just to show the version used, so I wouldn't be surprised if there's another spot like that.

@Cubik65536 That's the missing dependency ninja 1.12 exposes that I ran into, I made a patch with the four fixes combined for simplicity:

diff

```diff # https://chromium-review.googlesource.com/c/chromium/src/+/5641516 --- a/chrome/browser/ui/views/side_panel/BUILD.gn +++ b/chrome/browser/ui/views/side_panel/BUILD.gn @@ -201,5 +201,13 @@ "//ui/gfx:color_utils", "//ui/gfx/geometry:geometry_skia", "//ui/webui", + + # TODO(crbug.com/346711540,crbug.com/346699817,crbug.com/345645751): + # Use //chrome/browser/ui instead after fixing cyclic dependency. + "//chrome/browser/ui:webui_name_variants", + "//components/enterprise/buildflags", + "//components/paint_preview/buildflags", + "//components/segmentation_platform/public/proto", + "//components/webapps/common:mojo_bindings", ] } # https://chromium-review.googlesource.com/c/chromium/src/+/5646245 --- a/chrome/browser/ui/BUILD.gn +++ b/chrome/browser/ui/BUILD.gn @@ -6436,7 +6436,6 @@ } deps += [ - ":webui_name_variants", "side_search:side_search_tab_data_proto", "//base", "//chrome/browser:main_extra_parts", @@ -6495,7 +6494,10 @@ "//ui/lottie", "//ui/views:buildflags", ] - public_deps += [ "//ui/base/dragdrop/mojom:mojom_headers" ] + public_deps += [ + ":webui_name_variants", + "//ui/base/dragdrop/mojom:mojom_headers", + ] allow_circular_includes_from += [ "//chrome/browser/ui/views" ] # https://chromium-review.googlesource.com/c/chromium/src/+/5647662 --- a/chrome/browser/ui/BUILD.gn +++ b/chrome/browser/ui/BUILD.gn @@ -415,8 +415,10 @@ "//chrome/browser/ui/tabs:tab_enums", "//components/cross_device/logging", "//components/dom_distiller/core", + "//components/enterprise/buildflags", "//components/paint_preview/buildflags", "//components/safe_browsing:buildflags", + "//components/segmentation_platform/public", "//components/sync", "//components/sync_user_events", "//components/translate/content/browser", @@ -533,7 +535,6 @@ "//components/embedder_support:browser_util", "//components/encrypted_messages:encrypted_message_proto", "//components/enterprise", - "//components/enterprise/buildflags:buildflags", "//components/error_page/content/browser", "//components/facilitated_payments/core/features", "//components/favicon/content", @@ -644,7 +645,6 @@ "//components/security_interstitials/core:unsafe_resource", "//components/security_state/content", "//components/security_state/core", - "//components/segmentation_platform/public", "//components/send_tab_to_self", "//components/sessions", "//components/sharing_message", @@ -2119,7 +2119,6 @@ "//components/omnibox/browser:mojo_bindings", "//components/page_load_metrics/browser", "//components/paint_preview/browser", - "//components/paint_preview/buildflags", "//components/paint_preview/common", "//components/paint_preview/public", "//components/password_manager/content/common", # https://chromium-review.googlesource.com/c/chromium/src/+/5644627 --- a/chrome/browser/ui/views/side_panel/BUILD.gn +++ b/chrome/browser/ui/views/side_panel/BUILD.gn @@ -202,12 +202,24 @@ "//ui/gfx/geometry:geometry_skia", "//ui/webui", - # TODO(crbug.com/346711540,crbug.com/346699817,crbug.com/345645751): + # TODO(crbug.com/345645751): Use //chrome/browser instead after fixing cyclic dependency. + "//components/enterprise/common/proto:connectors_proto", + + # TODO(crbug.com/346711540,crbug.com/346699817,crbug.com/345645751, + # crbug.com/346694160,crbug.com/346709958,crbug.com/346707816): # Use //chrome/browser/ui instead after fixing cyclic dependency. + "//chrome/browser/cart:mojo_bindings", + "//chrome/browser/companion/visual_query", "//chrome/browser/ui:webui_name_variants", + "//chrome/browser/ui/webui/side_panel/bookmarks:mojo_bindings", + "//chrome/browser/ui/webui/side_panel/customize_chrome:mojo_bindings", + "//chrome/browser/ui/webui/side_panel/reading_list:mojo_bindings", "//components/enterprise/buildflags", + "//components/page_image_service/mojom:mojo_bindings", "//components/paint_preview/buildflags", "//components/segmentation_platform/public/proto", + "//components/user_education/webui", "//components/webapps/common:mojo_bindings", + "//ui/webui/resources/cr_components/commerce:mojo_bindings", ] } ```

Compiling for windows succeeded. We don't need the webnn removal patch anymore. And compiling bindgen using the script mentioned above seems to work as well.

While searching for the correct directx header commit I checked the ´.gitmodules´ file in in the chromium repo and noticed the gclient-condition = checkout_win entry for the directx submodule. I further investigated that and found out, that there is a potential bug or at least a possible improvement for our clone script: The target_os is hardcoded in the gclient config (https://github.com/ungoogled-software/ungoogled-chromium/blob/c407d7c81e38f80458997d26a164e968baa52e2e/utils/clone.py#L41). I think it would be nice to either have the target OS detected automatically or to specify it as a parameter for the clone script. I manually patched the target_os for now and will report back, once recompiling finished.

EDIT: I just read the note above the gclient config in the clone script which clearly states, that the config is made for compatibilty with the tarball rather than the target OS. The compatibility issue also came to my mind while further thinking about the implications of making the target OS configurable. I think this would (at least for windows) break the support for building releases using a tarball and I don't know if the want to got that way (yet).

While recompiling I wondered if we can exclude third_party/rust-toolchain from beeing synced by gsync. It's quite huge and most of the contents get pruned anyways...

I also wondered if anybody else encountered problems with libs being pruned from third_party/rust/chromium_crates_io. It's quite strange that they have those binary blobs under version control as they are available from creates.io was well. But I no idea how rust works and if creates.io is a trusted source for libs. I managed to find the required libs on GitHub but it's yet another thing to keep in mind when updating to a new version of chromium.

The script for compiling bindgen works indeed and should be used.

Now builds fine on macOS.

Yeah, we'd need to have each platform maintain their own separate pruning and domain substitution lists in order to use gsync that way.

I think removing third_party/rust-toolchain should be fine. it's one of largest directories other than instrumented_libs. I'll do some testing and add that along with the bump later today. I'll also remove the webnn patch as well since that's no longer causing issues.

What problems did you encounter with the crates directory? Maybe that is something else that should be added to the removals.

Yeah, we'd need to have each platform maintain their own separate pruning and domain substitution lists in order to use gsync that way.

Windows already maintains it's own pruning list as the binaries downloaded by gsync differs from the tarball. Thats no problem, for building with GIT we use our own pruning list, otherwise we use the pruning list from this repo. Having a platform dependant gsync config would break building with the tarball or at least making the update/build process more complicated.

I think removing third_party/rust-toolchain should be fine. it's one of largest directories other than instrumented_libs. I'll do some testing and add that along with the bump later today. I'll also remove the webnn patch as well since that's no longer causing issues.

Thanks :smile: This should speedup the build process as well.

What problems did you encounter with the crates directory? Maybe that is something else that should be added to the removals.

The lib for the windows-rs crate is located there which is required for the windows build process. I was able to fix the build process by downlading the libs from elsewhere and patching two .gn. But I think the crates directory will be used more in the future.

2. When pruning binaries, I got the following output: With no other information.

@Ahrotahn would it make sense to print that info even without debug mode?

--- a/utils/prune_binaries.py
+++ b/utils/prune_binaries.py
@@ -114,7 +114,7 @@
     unremovable_files = prune_files(args.directory, prune_list)
     if unremovable_files:
         get_logger().error('%d files could not be pruned.', len(unremovable_files))
-        get_logger().debug('Files could not be pruned:\n%s',
+        get_logger().error('Files could not be pruned:\n%s',
                            '\n'.join(f for f in unremovable_files))
         sys.exit(1)

The rust-toolchain is a gcs dep instead of a regular one, so I'll need to spend some more time figuring out the best way to handle that. Setting non_git_source to false looks like a good route since it would also clear up some other problematic paths, but I would need to spend some more time to add those as contingent paths and test that there aren't any issues building.

@PF4Public We could, though I feel like the only time someone would see that error is when the number of files is rather large so I'm not sure if that would be more help.

The CI ran out of memory running the clone so I'll wait for the tarball to release and rerun the check. I guess it might still be a good idea to increase the container soon anyways.

It seems that I cannot download the source of 127.0.6533.72 (URL returned 404).

Edit: .73 works though.

It should be available now

The rust-toolchain is a gcs dep instead of a regular one, so I'll need to spend some more time figuring out the best way to handle that. Setting non_git_source to false looks like a good route since it would also clear up some other problematic paths, but I would need to spend some more time to add those as contingent paths and test that there aren't any issues building.

We could delay those changes to the next minor update to reduce the workload for the current release.

127.0.6533.72 builds and runs fine on Artix Linux (Arch derivative)

127.0.6533.72 builds and runs fine on macOS

also .72 builds fine on portable linux and runs at least on manjaro, ubuntu 20.04/24.04 and fedora WS 40

hm, experiencing an issue that seems to be specific to ungoogled when trying to build on NixOS:

ninja: error: '../../third_party/node/linux/node-linux-x64/bin/node', needed by 'gen/ui/webui/resources/cr_components/commerce/path_mappings_build_path_map.json', missing and no known rule to make it

Patches mentioned previously for ui/webui/resources/cr_components/commerce don't seem to help either.

Since they have now added that path to the deps you'll have to create the link to node after running the pruning script, otherwise it will prune the link you made.

Ah, thanks, yes, that makes a lot of sense^^

The pruned binaries patch had a removal for [5596349]

PDF OCR was disabled in the patch previously, and now it seems to be enabled unconditionally. Do we need to continue disabling it further somehow?

It's still disabled. The only thing that's being allowed is some strings that are required for the settings webui.
This is because for some reason they gated those strings in the c++ code but not in the any of the html & js/ts which causes the browser to crash when visiting the settings because they aren't available.
Allowing those strings is much less invasive than ripping out all of the code that requires them.

ungoogled-software / ungoogled-chromium

Update to Chromium 127.0.6533.72 #2954

Changes:

Build notes: