search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Using performance patches from Thorium project #2969

Closed h4ckee closed 3 months ago

h4ckee commented 3 months ago

Description

Using performance patches from Thorium project

Who's implementing?

The problem

Hi guys. I've used Thorium browser (https://thorium.rocks) for awhile but found it a bit bloated, but it runs pretty fast, you can check the speed on https://browserbench.org/Speedometer3.0 As for Ungoogled-Chromium, in many cases it consumes CPU (even with libva-intel-driver in my case), when watching videos on Youtube.

Possible solutions

Don't you want to implement some of performance paches from Thorium to speed Ungoogled-Chromium up? Best regards, Sergey.

Alternatives

No response

Additional context

No response

networkException commented 3 months ago

I consider downstream "performance optimizations" for browser software to be snakeoil at best. Browser vendors, especially Google, pour millions into optimizing every last codepath of their engines.

lakdif commented 3 months ago

I never used that fork but seems like it has many issues of it's own regarding performance: https://github.com/Alex313031/Thorium-MacOS/issues/36

Most of it's "tweaks" are just some chrome://flags anyway

PF4Public commented 3 months ago

Duplicate of https://github.com/ungoogled-software/ungoogled-chromium/discussions/2372?

networkException commented 3 months ago

Right, wasn't able to find that because its a discussion.

Either way I personally don't think much of Thorium, they can do whatever but for this project I will be reluctant to adopt changes without individually reviewing if they're worthwhile and in scope.

For performance here, as stated previously, my opinions pretty much boil down to: Downstream can't optimize chromium further. I have prior experience to web engine development outside the chromium context and can confidently attest that optimizing mature (we're looking at over a decade of releases) engines is sisyphus work with yields below 1%

rany2 commented 3 months ago

At any rate, we aren't able to address compiler bugs which will definitely arise because of enabling such optimizations and really if Google doesn't have the capacity to deal with such issues and doesn't think it's worthwhile then it's really not worth it.