ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Add Google Search to list of installed search engines #2993

Closed jeffmcneill closed 3 months ago

jeffmcneill commented 3 months ago

Description

Add Google Search to list of installed search engines

Who's implementing?

The problem

When selecting a search engine, Google is not present. This requires googling, copying, and pasting codes to manually create the rather popular search engine as a default option. See: https://github.com/ungoogled-software/ungoogled-chromium/discussions/1488

Possible solutions

Add the Google search engine so that it is available as a choice from a list, rather than requiring the user to enter it manually.

Alternatives

No response

Additional context

No response

PF4Public commented 3 months ago

But the project is literally called "ungoogled"…

jeffmcneill commented 3 months ago

But the project is literally called "ungoogled"…

For Google services ... Nothing prevents someone from using a search engine of choice. This feature request, which I am offering to implement will make the software better for some set of users, without degrading the software for others.

"A foolish consistency is the hobgoblin of little minds." -- Emerson

jeffmcneill commented 3 months ago

Easy to fix:

https://github.com/ungoogled-software/ungoogled-chromium/blob/master/patches/core/ungoogled-chromium/replace-google-search-engine-with-nosearch.patch

PF4Public commented 3 months ago

Nothing prevents someone from using a search engine of choice.

Nothing prevents someone from using a search engine of choice at the current state. What is the problem again? One could add any search engine and it would be preserved in the profile, no need to do it more than once.

jeffmcneill commented 3 months ago

Why remove an option and require someone to add it back manually? The problem is one of usability and convenience.

PF4Public commented 3 months ago

The problem is one of usability and convenience.

Exactly! You nailed it! You cannot have both convenience and privacy at the same time, so everyone has to make their own informed decision and configure the browser accordingly. Unfortunately we cannot provide a one-size-fits-all solution.

jeffmcneill commented 3 months ago

How does having the search engine configuration present affect security? One does not necessarily increase security by adding inconvenience.

PF4Public commented 3 months ago

How does having the search engine configuration present affect security?

I didn't even mention security in my message :) Security — not really, privacy — I bet it does. In this particular case with google search engine at least.

adding inconvenience

There is no standardised measure of inconvenience, so it is a very subjective thing.

rany2 commented 3 months ago

Really there is no reason to remove Google search from the default list of search engines, especially given that we already have terrible (for privacy anyway) options in that list.

IMO the best path forward is to either:

Personally I'm in favor of the latter. It's really not straightforward to add Google to the list as a user because it seems that Google omits that OpenSearch XML for Chromium so it doesn't add itself to the list automatically. You might argue that "Ungoogled" Chromium has to be fully ungoogled, but I think that in this case it's fair to have an exception to that rule.

Not having it in the list inconveniences users but keeping it wouldn't do any harm so long as it's not the default. Why should Bing be on the list but not Google? It's not like it will phone home by keeping it as an option.

PF4Public commented 3 months ago

I think that in this case it's fair to have an exception to that rule.

The question would be then, whether it is a good thing to have google search engine to be available so easily for end-users. Yeah, now that I've written it, it looks funny :)

rany2 commented 3 months ago

I'd say it's a good thing from a harm reduction POV. Even though they're using Google search in UGC, it's still better than having them use Google in vanilla Chromium or Chrome. Making it harder wouldn't necessarily change anyone's mind, they'd probably be frustrated with themselves and uninstall.