search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Disable DownloadsPageReferrerUrl feature by default #2997

Closed MikeWang000000 closed 2 months ago

MikeWang000000 commented 3 months ago

Disable DownloadsPageReferrerUrl feature by default

This patch will disable DownloadsPageReferrerUrl feature by default.

The DownloadsPageReferrerUrl feature is introduced by https://chromium-review.googlesource.com/c/chromium/src/+/5589888 .

[Downloads] Show referrer url on chrome://downloads items

This swaps the existing download url on a download item with the referrer url. Clicking the link will open the download's referrer/origin in a new tab. It's wrapped behind a feature flag.

Since chromium 127, users are unable to get real download url from chrome://downloads.

For example, download this file using chromium: https://commondatastorage.googleapis.com/chromium-browser-official/chromium-128.0.6613.84.tar.xz

The chrome://downloads page only shows its referrer. Click "Copy Link Address" in the menu will get its referrer https://github.com/... instead of real download url https://commondatastorage.googleapis.com/....

1

If we copy this link and paste to omnibox to download (without referrer), the url part will be completely empty.

2

I don't think it is a meaningful feature. It makes user more difficult to get the real url (especially the download link has redirects). Also, the original url will be lost if we download mannually by url. Disable it so chromium's chrome://downloads will behave the same as before version 127.

3
PF4Public commented 3 months ago

Is it platform independent?

MikeWang000000 commented 3 months ago

Is it platform independent?

Yes, it is platform independent.

PF4Public commented 3 months ago

Disabling referrer (chrome://flags/#minimal-referrers) makes URL part be gone right from the first attempt. :)

MikeWang000000 commented 3 months ago

btw, chrome --disable-features=DownloadsPageReferrerUrl can be a quick fix. This patch makes this option the default.

I can verify that after applying this patch, we can see the url part with chrome://flags/#minimal-referrers enabled.

networkException commented 2 months ago

Nice patch, thanks!

I'd say we just wait for the next upstream bump to include this