Problem with chrome://settings/onStartup

Rusenche commented 2 months ago

OS/Platform

Windows

Installed

Other (please use 'Additional context' field below to mention how exactly)

Version

ungoogled-chromium_128.0.6613.84-1.1_windows_x64.zip

Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

Problem with chrome://settings/onStartup

How to Reproduce?

Steps to reproduce the issue:

When starting the portable file from point 1 of @Hibbiki and when loading chrome://settings/onStartup - we mark "Continue from where you left off". In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) remains exactly the same and the highlighted option continues to remain highlighted. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and the loaded tabs are exactly the same - everything is correct and that's how it should be.
When starting the portable file from point 2 of @teeminus and when loading chrome://settings/onStartup - we mark "Continue from where you left off". In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) changes from a menu with three possible options to a menu with 4 options. And the highlighted option is no longer highlighted. Even if you mark an option again, if you press F5 (Refresh) from the keyboard again - you see that the marked option is demarked again. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and nothing is saved anymore - there are no tabs - the previously loaded tabs are gone. I remind you that before restarting the browser, "Continue from where you left off" was marked. But practically this is not the case and it is a problem that the tabs are not saved.
When starting the portable file from point 3 of @macchrome / @winchrome and when loading chrome://settings/onStartup - we mark "Continue from where you left off". In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) changes from a menu with three possible options to a menu with 4 options. And the highlighted option is no longer highlighted. Even if you mark an option again, if you press F5 (Refresh) from the keyboard again - you see that the marked option is demarked again. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and nothing is saved anymore - there are no tabs - the previously loaded tabs are gone. I remind you that before restarting the browser, "Continue from where you left off" was marked. But practically this is not the case and it is a problem that the tabs are not saved.

Actual behaviour

Problem with chrome://settings/onStartup

Expected behaviour

Problem with chrome://settings/onStartup

Relevant log output

No response

Additional context

Hello

Problem with chrome://settings/onStartup

I don't know since when this problem occurred, but this problem is a fact.

Testing was done with:

chrome.nosync.7z - chromium-win64 v.128.0.6613.114-r1331488 - @Hibbiki - https://github.com/Hibbiki/chromium-win64/releases/tag/v128.0.6613.114-r1331488/ - https ://github.com/Hibbiki/chromium-win64/releases/download/v128.0.6613.114-r1331488/chrome.nosync.7z
ungoogled-chromium_128.0.6613.84-1.1_windows_x64.zip - @teeminus - https://github.com/ungoogled-software/ungoogled-chromium-windows/releases/download/128.0.6613.84-1.1/ungoogled-chromium_128.0.6613.84-1.1_windows_x64.zip
ungoogled-chromium-128.0.6613.114-1_Win64.7z - @macchrome / @winchrome - https://github.com/macchrome/winchrome/releases/tag/v128.6613.114-M128.0.6613.114-r1331488-Win64/

Steps to reproduce the issue:

When starting the portable file from point 1 of @Hibbiki and when loading chrome://settings/onStartup - we mark Continue from where you left off. In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) remains exactly the same and the highlighted option continues to remain highlighted. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and the loaded tabs are exactly the same - everything is correct and that's how it should be.
When starting the portable file from point 2 of @teeminus and when loading chrome://settings/onStartup - we mark Continue from where you left off. In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) changes from a menu with three possible options to a menu with 4 options. And the highlighted option is no longer highlighted. Even if you mark an option again, if you press F5 (Refresh) from the keyboard again - you see that the marked option is demarked again. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and nothing is saved anymore - there are no tabs - the previously loaded tabs are gone. I remind you that before restarting the browser, Continue from where you left off was marked. But practically this is not the case and it is a problem that the tabs are not saved.
When starting the portable file from point 3 of @macchrome / @winchrome and when loading chrome://settings/onStartup - we mark Continue from where you left off. In this case, we experimentally press the keyboard key F5 (refresh) several times and the page menu (chrome://settings/onStartup) changes from a menu with three possible options to a menu with 4 options. And the highlighted option is no longer highlighted. Even if you mark an option again, if you press F5 (Refresh) from the keyboard again - you see that the marked option is demarked again. Then in a new tab we load any site - any - even https://github.com/. You restart the browser and nothing is saved anymore - there are no tabs - the previously loaded tabs are gone. I remind you that before restarting the browser, Continue from where you left off was marked. But practically this is not the case and it is a problem that the tabs are not saved.

And now I am attaching pictures to visualize the problem.

@Hibbiki - v.128.0.6613.114: Everything is correct here and that's exactly how it should be.

https://i.postimg.cc/mrg2gyjW/Hibbiki-v-128-0-6613-114.png

Hibbiki - v 128 0 6613 114

@teeminus - v.128.0.6613.84-1.1 before refresh (F5) - https://i.postimg.cc/V6Sfjs27/teeminus-v-128-0-6613-84-1-1-before-refresh.png

teeminus - v 128 0 6613 84-1 1 before refresh

@teeminus - v.128.0.6613.84-1.1 after refresh (F5) - https://i.postimg.cc/FFLFzRyz/teeminus-v-128-0-6613-84-1-1-after-refresh.png

teeminus - v 128 0 6613 84-1 1 after refresh

I don't need to show an image that doesn't have any tabs loaded because that's how the browser loads in scenarios 2 and 3.

I'm not attaching a picture for @macchrome / @winchrome because there browser behavior is exactly the same as @teeminus's browser behavior.

BabyFnord commented 2 months ago

Same behaviour confirmed for eloston-chromium 128.0.6613.84 (Official Build, ungoogled-chromium) (arm64) on a fresh macOS and Chromium install: Except for adding custom search engines and setting them as standard, nothing else is persistent in chrome://settings/.

Ahrotahn commented 2 months ago

I could reproduce this under wine and did a little debugging. I think the problem is due to setting an internationalization id to an empty string rather than the label it's meant for.

I only have a linux build environment available at the moment, so if anyone on the @ungoogled-software/windows team has the time, see if applying this after the ungoogled-chromium patches solves the issue:

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.ts
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.ts
@@ -521,15 +521,11 @@
         i18nId = 'classicTheme';
         break;
     }
+    this.themeSublabel_ = this.i18n(i18nId);
     // </if>
     // <if expr="not is_linux">
-    if (this.toolbarPinningEnabled_) {
       this.themeSublabel_ = '';
-      return;
-    }
-    i18nId = '';
     // </if>
-    this.themeSublabel_ = this.i18n(i18nId);
   }

   /** @return Whether applied theme is set by policy. */

trueno2k commented 2 months ago

If anyone is having this issue with saving chrome://settings/onStartup setting to "continue where you left off" or "open a specific page or set of pages" setting, then all you have to do for now is go to "About Chromium" option on the "three dots" menu and then there click on "On start-up" option in Settings and that will allow you set your tabs saves settings again. If you're already in Settings, then click on "About Chromium" then click back "On start-up" and that will do the same thing as above. NB. To add to this if you already clicked on "On start-up" option once while in settings, you then have to exit settings and and then do the above trick again or the "On start-up" setting will revert back to nothing / no tabs saved and this may cause some other issues if you already have tabs saved before this "On start-up" issue appeared. Hopes this helps for now...

Nifury commented 2 months ago

see if applying this after the ungoogled-chromium patches solves the issue:

Yes, just confirmed that this patch solves the issue. Thanks!

trueno2k commented 2 months ago

Apparently this issue isn't an ungoogled-chromium issue this issue is actually happening to official build of the chrome browser, I tested the bug on the 128.0.6613.114 release of chrome browser on windows and this issue still exists there aswell, so I would hazard a guess this issue can not be resolved by the devs here, no?

EDIT: Just updated to 128.0.6613.120 release on official chrome browser, and it seems to now allow you set the "On Startup" setting, but click on the "About Chrome" and back to "On Startup" it seems to reset the setting, just need to from the three-dot menu click settings and your previous "On Startup" saved settings should re-appear. There's no need to exit settings if you're already have it opened.

Rusenche commented 2 months ago

@trueno2k, I understood this scenarios.

Since I do not install, but I always use portable versions, I tested with the latest and current version of @hibbiki from here: https://github.com/Hibbiki/chromium-win64/releases/tag/v128.0.6613.120-r1331488/.

Even with your scenarios with this portable version, everything is accurate. But ... If you hold the F5 key constantly when you are on chrome://settings/onStartup - then in short moments (milliseconds) a fourth row with menu appears, but when you stop pressing the F5 key - the rows are only 3 - As it should be. There is probably something problematic somewhere and I have no idea if the proposed correction works, because the current new version of @teeminus - https://github.com/ungoogled-software/ungoogled-chromium-windows/releases/tag/128.0.6613.119-1.1 does not include the fix (https://github.com/ungoogled-software/ungoogled-chromium/pull/3017), which was specified here https://github.com/ungoogled-software/ungoogled-chromium-windows/pull/379#issuecomment-2327278015. In other words - we do not know yet whether the proposed fix is functioning properly.

Just in case I tested with v.130.0.6700.0 (1351337) (05.09.2024) (https://storage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/1351337/).

And in this version, if you keep a constantly pressed F5 key when you are on chrome://settings/onStartup - then in the short moments (milliseconds) appears the fourth row with a menu, but when you stop pressing the F5 key - the lines are only the rows 3 - as it should be. This problem unnoticed was carried to version 130...

Rusenche commented 2 months ago

@macchrome / @winchrome / @marmaduke has fixed the issue by applying Patch applied. Already posted ungoogled-chromium-128.0.6613.132-2_Win64.7z - https://github.com/macchrome/winchrome/releases/tag/v128.6613.132-M128.0.6613.132-r1331488-Win64/ and indeed no problem anymore.

I guess when @teeminus applies the patch for a future version, the problem would be solved, but for now there is no such version from him, will wait for the next official release from Chromium.

Rusenche commented 2 months ago

I confirm that with the current version Ungoogled chromium v.128.0.6613.137-1.1 (https://github.com/ungoogled-software/ungoogled-chromium-windows/releases/tag/128.0.6613.137-1.1) the issue is resolved.

Thanks everyone.

ungoogled-software / ungoogled-chromium