ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Add missing re2 deps #3036

Closed iskunk closed 1 month ago

iskunk commented 2 months ago

The u-c build fails in a couple of places due to missing re2 dependencies, that the upstream build supplies via a component that we remove (per @Ahrotahn):

FAILED: obj/components/plus_addresses/plus_addresses/plus_address_service.o
[...]
In file included from ../../components/plus_addresses/plus_address_service.cc:31:
In file included from ../../components/plus_addresses/plus_address_blocklist_data.h:11:
../../third_party/re2/src/re2/re2.h:223:10: fatal error: 're2/stringpiece.h' file not found
#include "re2/stringpiece.h"
         ^~~~~~~~~~~~~~~~~~~

FAILED: obj/components/component_updater/installer_policies/installer_policies_no_content_deps/plus_address_blocklist_component_installer.o
[...]
In file included from ../../components/component_updater/installer_policies/plus_address_blocklist_component_installer.cc:18:
In file included from ../../components/plus_addresses/plus_address_blocklist_data.h:11:
../../third_party/re2/src/re2/re2.h:223:10: fatal error: 're2/stringpiece.h' file not found
#include "re2/stringpiece.h"
         ^~~~~~~~~~~~~~~~~~~

(This build failure was first reported here.)

This PR adds the re2 deps to missing-dependencies.patch, as advised.