search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Enable extra locales not normally shipped with Chromium on desktop #3072

Closed PF4Public closed 3 weeks ago

PF4Public commented 3 weeks ago

Google does not ship some of the locales on desktop by default, we can fix that :) Tested on Linux: image

It'd be great if @Cubik65536 could test the patch on Mac and @Nifury or @teeminus on Windows.

Cubik65536 commented 3 weeks ago

So just to make sure, we're testing if Sinhalese (si) (and similar disabled by default locales) is enabled after building with this patch?

PF4Public commented 3 weeks ago

So just to make sure, we're testing if Sinhalese (si) (and similar disabled by default locales) is enabled after building with this patch?

Exactly.

Cubik65536 commented 3 weeks ago

CleanShot 2024-10-27 at 01 30 14

CleanShot 2024-10-27 at 01 31 13

Works on macOS (130.0.6723.69 arm64)!

Nifury commented 3 weeks ago

image

Works on Windows as well!

clickot commented 3 weeks ago

@PF4Public: layman question: Doesn't it depend on what fonts are installed on a linux system (and how they are configured) if such languages are properly displayed? I ask because I struggled with Farsi to get properly displayed in browsers on Linux (always ended up with arabic symbols instead of persian which are somewhat similar but not the same). Or does this PR only concern the display language of the browser itself, not websites?

PF4Public commented 3 weeks ago

Or does this PR only concern the display language of the browser itself, not websites?

Only the UI language.

Doesn't it depend on what fonts are installed on a linux system. […] I struggled with Farsi to get properly displayed in browsers on Linux

In simple cases yes. I got used to have Noto on my machines to cover maximum glyphs possible. So if one of the fonts does not have needed glyphs browsers substitute from Noto. But your case is something else. I couldn't even think of browsers confusing writing systems. :-/ Have you tried to install the whole Noto family? Have you tried searching skia/harfbuzz bugtracker? It is very improbable that no one else noticed.