search

ungoogled-software / ungoogled-chromium

Google Chromium, sans integration with Google
BSD 3-Clause "New" or "Revised" License
20.8k stars 844 forks source link

Manually set up gsutil path for newer versions of Python #3079

Closed Ahrotahn closed 1 week ago

Ahrotahn commented 2 weeks ago

This PR adds a new section to the clone script that manually sets up the gsutil directory with a newer version of apitools so Python 3.13+ can be used.

Normally gsutil creates this path during runtime and makes an install.flag file to signify completion so it only needs to do the work once. This change writes to the same file in order to prevent gsutil from overwriting our changes.

Ahrotahn commented 2 weeks ago

@tsuliwaensis @teeminus @clickot Let me know if that gives you any trouble. This method is more involved but should hopefully avoid the platform-specific pitfalls.

tsuliwaensis commented 2 weeks ago

I was able to run the clone script with Python 3.13

teeminus commented 2 weeks ago

No issues on windows 👍

clickot commented 2 weeks ago

Additionally to the sysroot feature I use a debian-bullseye based docker image for the build to ensure that the build result runs on older linux versions. In this docker image is a python 3.9.2. In this setting the clone script runs fine and the build executes normally :+1: