Closed kariedo closed 5 years ago
same as #672
problem is like me you did
git clone https://github.com/Eloston/ungoogled-chromium.git
but you have to do:
git clone --branch 71.0.3578.98-2 https://github.com/Eloston/ungoogled-chromium.git
before following those instructions:
# Run from inside the clone of the repository
mkdir -p build/src/ungoogled_packaging
python3 get_package.py macos build/src/ungoogled_packaging
cd build/src
./ungoogled_packaging/build.sh
/build/config/compiler/BUILD.gn section in fix-gn-safe_browsing.patch seems to be the cause of the problem. You can compile if you delete this section from the patch file, though I don't know how safe that is.
@patchouli69ou ~~I removed all the references to safe browsing and this is what I get: ../../third_party/skia/include/core/../private/SkOnce.h:13:10: fatal error: 'SkTypes.h' file not found
^~~~~~~~~~~
1 warning and 1 error generated. ninja: build stopped: subcommand failed. I don't get it.~~
Update: it worked just fine. You rock. I wasn't disabling the patch properly.
The first part of the patch @patchouli69ou is referring to commented out the flag, but that has been completely removed from chromium in October, see: https://bugs.chromium.org/p/chromium/issues/detail?id=753973 I'm opening a quick PR for this.
Description
Build fails on macOS for 72.0.3626.96
Console output and logs
Environment details
72.0.3626.96
]macos
]macos
]macOS 10.14
]clang+llvm-6.0.0-x86_64-apple-darwin
]Building and packaging steps
Followed the instructions: