search

unhammer / zotero-natbib

Zotero BibTeX translator for natbib format
3 stars 0 forks source link

Filing a pull request to https://github.com/zotero/translators? #1

Open mcepl opened 12 years ago

mcepl commented 12 years ago

Why didn't you send your patch to the upstream repo? I have now hard time to decide whether your changes are now redundant (as some seem to be) or not.

unhammer commented 12 years ago

I reported the "ø" issue to someone in some zotero forum, and from https://github.com/unhammer/zotero-natbib/commit/1a5d02b1f2b363fa79bfed5ff1a1c33591bc0feb#BibTeX-natbib.js it shouldn't be too hard to tell whether it's fixed upstream or not. (I thought zotero used svn, how long has it been on github?)

The only other changes are https://github.com/unhammer/zotero-natbib/commit/aa61714cb0a888b8bc325264619f0850f4249d8a#BibTeX-natbib.js which do two things:

1) ensure title/booktitle/journaltitle have {} around them (makes bibtex use the user-specified capitalisation instead of guessing it); this is probably useful to have upstream,

2) puts the date in the 'lastchecked' field instead of writing a full string in the 'howPublished' field. If you don't use natbib, it may be better to leave out this change, since not all bibtex styles are able to use the lastchecked field.

mcepl commented 12 years ago

Probably not whole Zotero, but translators are on github https://github.com/zotero/translators