unhcr / koboloadeR

deprecated please use {kobocruncher} - https://edouard-legoupil.github.io/kobocruncher/
https://unhcr.github.io/koboloadeR/docs/
28 stars 28 forks source link

Data downloading uses base get instead of httr::GET #82

Open tomsmekens opened 2 years ago

tomsmekens commented 2 years ago

In a commit to "fix issues for CRAN Registration", in the function get_me located in utils.R, a GET function call was inadvertently changed to get; GET is from the httr package and is used for downloading URLs, whereas get is a base function with a completely different purpose, namely to get a variable from a specified environment. A mishap when applying code style settings?


Context

I tried using both kobo_datasets and kobo_data_downloader with the current version. They worked in an older version I downloaded from mrdwab/koboloadeR.

Problem

Error message.

Expected result

Downloading of the data/listing of the datasets, which worked in version 0.1.2.

Current result

invalid 'envir' argument

Possible Fix

In utils.R, in function get_me, change get to httr::GET.