uni-helper / uni-network

为 uni-app 打造的基于 Promise 的 HTTP 客户端
https://uni-network.netlify.app
MIT License
76 stars 8 forks source link

fix: replace statuses with statuses-es for better compact compatibility #53

Closed wtto00 closed 2 months ago

wtto00 commented 2 months ago

Description 描述

在新版本的uniapp,具体是版本号大于 40204 的项目中,运行项目 pnpm dev:mp-weixin ,会抛出以下错误:

​node_modules/@uni-helper/uni-network/node_modules/statuses/index.js (8:7): Error when using sourcemap for reporting an error: Can't resolve original location of error.​
node_modules/@uni-helper/uni-network/node_modules/statuses/index.js (8:7): "default" is not exported by "E:/projects/github/uni-helper/uni-network/playground/node_modules/@uni-helper/uni-network/node_modules/statuses/codes.json?commonjs-proxy", imported by "node_modules/@uni-helper/uni-network/node_modules/statuses/index.js".
file: E:/projects/github/uni-helper/uni-network/playground/node_modules/@uni-helper/uni-network/node_modules/statuses/index.js:8:7

 6:  */
 7: import * as commonjsHelpers from "commonjsHelpers.js";
 8: import require$$0 from "\u0000E:/projects/github/uni-helper/uni-network/playground/node_modules/@uni-helper/uni-netwo...
           ^
 9:
10: 'use strict'

at ../node_modules/@uni-helper/uni-network/node_modules/statuses/index.js:8:7
   6:  */
   7: import * as commonjsHelpers from "commonjsHelpers.js";
   8: import require$$0 from "\u0000E:/projects/github/uni-helper/uni-network/playground/node_modules/@uni-helper/uni-netwo...
             ^
   9:
  10: 'use strict'

Linked Issues 关联的 Issues

fix #52

Additional context 额外上下文

按照 @ModyQyW 的方法,将依赖 statuses 替换为 statuses-es

Summary by CodeRabbit

Release Notes

These changes aim to streamline the documentation and enhance the project's maintainability.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes in this pull request involve updates to the documentation and dependencies related to the statuses library. The README.md and error handling documentation have been revised to reference the new statuses-es library instead of the original statuses. Additionally, the package.json file has been modified to remove the old statuses and its type definitions, replacing them with statuses-es. Import statements in several TypeScript files have also been updated to reflect this change.

Changes

File Change Summary
README.md, docs/advanced/handling-errors.md Updated references from statuses to statuses-es in documentation.
packages/core/package.json Removed @types/statuses and statuses; added statuses-es with version ^2.0.6.
packages/core/src/adapters/*.ts Changed import statements from "statuses" to "statuses-es" in download.ts, request.ts, and upload.ts.

Assessment against linked issues

Objective Addressed Explanation
有个依赖报错?? (Issue #52)

🐇 In the meadow, changes bloom,
New statuses rise, dispelling gloom.
From statuses to statuses-es, we leap,
A hop of progress, no need to weep!
Code is fresh, dependencies align,
Hooray for updates, all is fine! 🌼


Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between fbd1046d098c7af054a884e29979388c6f893d3a and dabadeba39a408d410e67c6ffb6cb085449658d0.
Files selected for processing (1) * README.md (1 hunks)
Files skipped from review as they are similar to previous changes (1) * README.md
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 months ago

Deploy Preview for uni-network ready!

Name Link
Latest commit dabadeba39a408d410e67c6ffb6cb085449658d0
Latest deploy log https://app.netlify.com/sites/uni-network/deploys/66ec53c52f10a90008e7bad7
Deploy Preview https://deploy-preview-53--uni-network.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@uni-helper/uni-network@53

commit: dabadeb

ModyQyW commented 2 months ago

Thank you!