uni-helper / vite-plugin-uni-layouts

为 Vite 下的 uni-app 提供类 nuxt 的 layouts 系统
MIT License
25 stars 6 forks source link

fix: fix HBuilderX compatibility #33

Closed Xiphin closed 2 months ago

Xiphin commented 2 months ago

Description 描述

最小修改兼容 HBuiderX 运行模式

Linked Issues 关联的 Issues

在 HBuiderX 使用不生效

Additional context 额外上下文

在 HBuilderX 下运行

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes introduce enhanced configurability by enabling dynamic specification of the JSON pages path. Users can now define the path using the pagesJsonPath property in the Options interface. This update ensures consistent handling of the path across Context, types, and utils, fostering system flexibility and simplifying maintenance.

Changes

Files Changes Summary
src/context.ts Updated loadPagesJson to use this.options.pagesJsonPath for loading JSON pages.
src/types.ts Added pagesJsonPath property to the Options interface.
src/utils.ts Enhanced resolveOptions with pagesJsonPath support; improved getTarget logic.

🐰✨ In the code woods, a new path unfurls, pagesJsonPath now, for JSON pearls. src and utils in harmony align, Configurable paths, a paradigm. Files dance, in the winds of change, A symphony of code, rearrange! 🌟 🐰💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Xiphin commented 2 months ago

@KeJunMao 方便看一下么?

ModyQyW commented 2 months ago

LGTM

Xiphin commented 2 months ago

pagesJsonPath 这个属性的有无可能不会产生太大影响 我觉得可以通过判断是否拥有 src目录 来区分所创建项目类型就好了

这是我的看法,看看大佬们怎么说?🧐

同时要谢谢你的PR,解决 HBuilderX 上的问题 ❤

HBuilderX 和 Cli 两种模式下 pages.json 文件所在的路径不一样,之前的代码似乎是写死的,一起看一下 https://github.com/uni-helper/vite-plugin-uni-layouts/blob/eb9eabc0e26572298404a4113087d07f7fd561dc/src/context.ts#L36

https://github.com/uni-helper/vite-plugin-uni-layouts/blob/eb9eabc0e26572298404a4113087d07f7fd561dc/src/context.ts#L47

Xiphin commented 2 months ago

pagesJsonPath 这个属性的有无可能不会产生太大影响 我觉得可以通过判断是否拥有 src目录 来区分所创建项目类型就好了

这是我的看法,看看大佬们怎么说?🧐

同时要谢谢你的PR,解决 HBuilderX 上的问题 ❤

你的意思是定义一个全局 isSrc 模式的判断,对吧?

Skiyee commented 2 months ago

你的意思是定义一个全局 isSrc 模式的判断,对吧?

https://github.com/uni-helper/vite-plugin-uni-layouts/blob/a3c243bae9948baebd7f3e05c8c2048fde882356/src/utils.ts#L48-L50

是的,就像你处理这个类似 👆

因为在我看来,判断不同创建项目模式,无非就两种可能,pages.jsonsrc根目录

Xiphin commented 2 months ago

你的意思是定义一个全局 isSrc 模式的判断,对吧?

https://github.com/uni-helper/vite-plugin-uni-layouts/blob/a3c243bae9948baebd7f3e05c8c2048fde882356/src/utils.ts#L48-L50

是的,就像你处理这个类似 👆

因为在我看来,判断不同创建项目模式,无非就两种可能,pages.jsonsrc根目录

看了一下 在 src/context.ts 全局 isSrc 判断貌似找不到合适的位置

你觉得在哪个位置合适?

KeJunMao commented 2 months ago

是不是直接检测是否存在就可以,优先 src/pages.json,回退 pages.json,都没有抛出

Xiphin commented 2 months ago

是不是直接检测是否存在就可以,优先 src/pages.json,回退 pages.json,都没有抛出

调整优化了一下,大家再看一下 (https://github.com/uni-helper/vite-plugin-uni-layouts/pull/33/commits/df27b8e38a5d7095dd2ec72ba2aaee34c5ae1fc6)

@Skiyee @KeJunMao

Skiyee commented 2 months ago

LGTM ❤

https://github.com/uni-helper/vite-plugin-uni-layouts/blob/eb9eabc0e26572298404a4113087d07f7fd561dc/src/index.ts#L32

这一行可能需要改成这样,const filter = createFilter(['main.(ts|js)', 'src/main.(ts|js)'])

Xiphin commented 2 months ago

@Skiyee 看一下

ModyQyW commented 2 months ago

如果没有进一步反馈,我会在2-3天内合并发布。

ModyQyW commented 2 months ago

Thank you!