fix(utils): fix path's format error

Skiyee commented 6 months ago

fixes: #36

😅 这BUG有点尴尬，以后的PR还是得先通过test

Summary by CodeRabbit

New Features
- Improved path resolution logic for better handling of different modes. This ensures more reliable loading of configuration files and error messages.
Bug Fixes
- Enhanced error messaging for missing pages.json file, providing clearer guidance for resolving issues.

coderabbitai[bot] commented 6 months ago

Walkthrough

The changes introduce a new utility function isCLIMode in src/utils.ts to determine if a path includes 'src/'. This function is then utilized in loadPagesJson and getTarget functions for path resolution, enhancing the accuracy of path checks and error messages.

Changes

File	Change Summary
`src/utils.ts`	Introduced `isCLIMode` function, updated `loadPagesJson` to use `isCLIMode` for path checks, and modified `getTarget` to utilize `isCLIMode` for path resolution.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure path resolution accommodates CLI mode (#36)	✅
Update error message for missing `pages.json` (#36)	✅

In the code, a change so bright, Paths now check if CLI's in sight. With isCLIMode to guide the way, Errors clearer, no more dismay. A rabbit's touch, to make it right. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Xiphin commented 5 months ago

没测试 windows 环境不好意思

Skiyee commented 5 months ago

没测试 windows 环境不好意思

没问题的 ❤

是我们 reviewer 没做测试，算是我们的问题

ModyQyW commented 5 months ago

俺没有 windows😢

ModyQyW commented 5 months ago

Thank you!

Skiyee commented 5 months ago

俺没有 windows😢

那有可能就我是window，尴尬了这下

Xiphin commented 5 months ago

isCLIMode

俺没有 windows😢

我也没有 😂

Xiphin commented 5 months ago

@ModyQyW 这次你草率了发版太快了

Xiphin commented 5 months ago

loadPagesJson 在 context.ts 里的入参是 src/pages.json，isCLIMode 始终是 true

Skiyee commented 5 months ago

loadPagesJson 在 context.ts 里的入参是 src/pages.json，isCLIMode 始终是 true

hx 创建得项目是不是得修改layoutDir这个属性？

Xiphin commented 5 months ago

loadPagesJson 在 context.ts 里的入参是 src/pages.json，isCLIMode 始终是 true

hx 创建得项目是不是得修改layoutDir这个属性？

跟 layoutDir 没关系是解析不到 pages.json 文件

Skiyee commented 5 months ago

跟 layoutDir 没关系是解析不到 pages.json 文件

我知道问题，我要通过layoutDir来判断什么模式创建的项目

Xiphin commented 5 months ago

跟 layoutDir 没关系是解析不到 pages.json 文件

我知道问题，我要通过layoutDir来判断什么模式创建的项目

这个也不严谨，因为 layoutDir 是用户自己可以指定的任意目录

Xiphin commented 5 months ago

https://github.com/uni-helper/vite-plugin-uni-layouts/pull/39

uni-helper / vite-plugin-uni-layouts