uni-helper / vite-plugin-uni-pages

为 Vite 下的 uni-app 提供基于文件系统的路由
https://uni-helper.js.org/vite-plugin-uni-pages
MIT License
104 stars 15 forks source link

fix(core): fix subPackage cannot exceed the second-level dir #155

Closed Skiyee closed 4 months ago

Skiyee commented 4 months ago

修复当分包拥有二级目录以上时,root和path路径无法正确生成问题

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The update involves enhancing the directory scanning functionality in a software project by introducing a new method to fetch subdirectories and refining existing methods for better path handling. Additionally, new Vue components were added to display simple messages, and the testing suite was updated to accommodate the new directory scanning capabilities.

Changes

File Path Change Summary
packages/core/src/context.ts Added getSubPageDirs, updated scanSubPages to use new method, modified path logic in parsePages
packages/core/src/files.ts Introduced getSubPageDirs function to fetch subdirectories
.../pages-sub-more/home/pages/about/index.vue Added index.vue with a greeting message in 'about' directory
.../pages-sub-more/home/pages/index.vue New index.vue as the home section index page
.../pages-sub-more/user/pages/index.vue New index.vue as the user section index page
test/generate.spec.ts Updated imports and test cases to support new directory scanning functionality

🐰🌟✨
In the land of code, where directories sprawl,
A rabbit hopped, adjusting paths so tall.
With a flick and a function, subdirs align,
"Hello from pages!" they cheerfully chime.
Oh, what joy these new changes bring,
In the heart of the code, where rabbits sing!
🌟✨🐰


Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between c436cc7fa54aeb32ce51c5270203bdf0163a0bac and 8a981c3f6b5b8edb245b44e0fbd5c5e118be4c7d.
Files selected for processing (6) * packages/core/src/context.ts (3 hunks) * packages/core/src/files.ts (1 hunks) * packages/playground/src/pages-sub-more/home/pages/about/index.vue (1 hunks) * packages/playground/src/pages-sub-more/home/pages/index.vue (1 hunks) * packages/playground/src/pages-sub-more/user/pages/index.vue (1 hunks) * test/generate.spec.ts (3 hunks)
Files skipped from review due to trivial changes (3) * packages/playground/src/pages-sub-more/home/pages/about/index.vue * packages/playground/src/pages-sub-more/home/pages/index.vue * packages/playground/src/pages-sub-more/user/pages/index.vue
Additional comments not posted (7)
packages/core/src/files.ts (1)
`25-31`: The implementation of `getSubPageDirs` correctly retrieves directories using `fg.sync` with the `onlyDirectories` option.
test/generate.spec.ts (3)
`1-1`: Correct addition of the `it` import from 'vitest' for use in test cases. --- `95-95`: Modification of `PageContext` instantiation aligns with the updated logic for handling pages without merging. --- `176-210`: The addition of the new test case to support glob patterns in `subPackages` is correctly implemented and necessary for verifying the new functionality.
packages/core/src/context.ts (3)
`22-22`: Correct addition of `getSubPageDirs` to the import statements to support its usage in `scanSubPages`. --- `88-95`: The updated logic in `scanSubPages` correctly uses `getSubPageDirs` to handle deeper directory structures in subpackages. --- `248-249`: The modifications in `parsePages` correctly calculate the `basePath` and `root` paths, ensuring accurate path generation for nested directories.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.