search

uni-helper / vite-plugin-uni-pages

为 Vite 下的 uni-app 提供基于文件系统的路由
https://uni-helper.js.org/vite-plugin-uni-pages
MIT License
104 stars 15 forks source link

fix(core): fix subPackage cannot match the second-level dir #161

Closed Skiyee closed 4 months ago

Skiyee commented 4 months ago

fixes: #152

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The update primarily involves adjusting path calculations in the PageContext class to better handle sub-package directories, alongside adding simple templates for new vue files in various sub-pages. A test case was also introduced to ensure correct path matching for sub-packages in nested directories.

Changes

File Path Change Summary
packages/core/src/context.ts Modified path calculation to incorporate basePath derived from project options.
packages/playground/src/.../about/index.vue Added new vue files in about sub-pages across sub-activity and sub-main directories.
packages/playground/src/.../home/index.vue Added new vue files in home sub-pages across sub-activity and sub-main directories.
test/generate.spec.ts Added it function import and a new test case to fix sub-package path matching for nested dirs.

Assessment against linked issues

Objective Addressed Explanation
Support sub-packages in pages directory (#152) ✅

Poem

🐇 Ode to the Code Update 🌟

In the burrows of the code, deep and wide,
Paths intertwine where sub-packages reside.
A rabbit hops through, with a fix in its stride,
Now all can nest, in pages with pride.
Cheers to the paths, now correctly allied!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ModyQyW commented 4 months ago

LGTM

Shigukj commented 4 months ago

正是我需要的

wukongkong commented 4 months ago

感谢~

ModyQyW commented 4 months ago

如果没有进一步需要修改的反馈，我计划在明天合并并发布该 PR

ModyQyW commented 4 months ago

Thank you!

DuduStyle commented 2 months ago

新的配置规则是什么？没看明白？ subPackages: ['src/sub-pages', 'src/sub-pages/report'], 此类配置形式，sub-pages分包的内容里依然包含report路由 @ModyQyW @Skiyee

Skiyee commented 2 months ago

该配置是指定某个文件夹让其成为分包的

如果把 src/sub-pages 当成分包，那么此时在该文件夹下的 视图文件(无论在哪个层级) 都会被当作 “页面”

PS: 建议不要在分包内再嵌套分包