fix: resolve path in HBuilderX

Xiphin commented 4 months ago

Description 描述

子包目录解析会报错：

解决办法：

https://github.com/uni-helper/vite-plugin-uni-pages/blob/4459a1bfaa6d14becd56f0272ee62f5705daea9e/packages/core/src/context.ts#L245 改成：

      const root = slash(path.relative(basePath, path.join(this.options.root, dir)))

Linked Issues 关联的 Issues

无

Additional context 额外上下文

在 HBuilderX 下运行

Summary by CodeRabbit

Refactor
- Enhanced the calculation of the base path in the application to include additional path components, improving navigation and resource management.

coderabbitai[bot] commented 4 months ago

Walkthrough

The update in the PageContext class involves a modification to how the root variable is computed. It now integrates an additional path component, enhancing its configuration flexibility by incorporating this.options.root during the path calculation.

Changes

File Path	Change Summary
`.../core/src/context.ts`	Modified the calculation of the `root` variable in `PageContext` to include `this.options.root` in its path.

🐇💻 A whimsical code hop,
Changes drop, non-stop.
Paths extend, roots entwine,
In the burrow of code, all align.
Celebrate the tweak, so fine! 🌟
~ CodeRabbit 🎩🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

ModyQyW commented 4 months ago

这里是不是直接 const root = slash(path.relative(basePath, this.options.root, dir)) 就好了？

Xiphin commented 4 months ago

这里是不是直接 const root = slash(path.relative(basePath, this.options.root, dir)) 就好了？

relative(from: string, to: string): string

relative 函数应该只有两个入参

ModyQyW commented 3 months ago

这里是不是直接 const root = slash(path.relative(basePath, this.options.root, dir)) 就好了？
relative(from: string, to: string): string
relative 函数应该只有两个入参

确实，是我一时眼花看错了，不好意思😵‍💫

ModyQyW commented 3 months ago

LGTM

uni-helper / vite-plugin-uni-pages