search

uniVocity / univocity-trader

open-source trading framework for java, supports backtesting and live trading with exchanges
578 stars 140 forks source link

Broken build #127

Closed drkarl closed 3 years ago

drkarl commented 3 years ago

PR https://github.com/uniVocity/univocity-trader/pull/116 introduces half-made changes including breaking changes in interfaces, commented code including constructors and methods that are called by other classes.

Ideally the user who submitted the PR should complete the changes to fix the compilation issues. For now the only workaround is to exclude module univocity-trader-binance-future from maven build, so maybe that PR should be reverted until a new PR with the completed code is re-submitted.

In addition to that, test MarketSimulation.testMarketOrders is failing

Results :

Failed tests:   testMarketOrders(com.univocity.trader.scenarios.MarketSimulation): expected:<1225.636493> but was:<1000.0>
drkarl commented 3 years ago

@hlevel it looks like you unintendedly merged some code that was in the middle of some changes including commented blocks of code on PR #116, which breaks the build. It would be great if you could submit a new PR once you complete those changes and the build is fixed again. Thank you!

hlevel commented 3 years ago

@drkarl This unit test has been changed all over, and it is no longer in use. Error reporting can be deleted. I've tested all of them.

drkarl commented 3 years ago

Thanks for your reply @hlevel. I was not referring to the failing unit test, there's some code in the univocity-trader-binance-future that doesn't compile, because there's commented code and some parameters on interfaces have changed... but it seems that the changes are half-done so it doesn't compile.

hlevel commented 3 years ago

@drkarl Is there a code error example? I'm very normal here and I've run it online successfully.

drkarl commented 3 years ago

On the commit c0d8619c7c9142b4da19fb68593b5426ff822338 which is just before my 2 PRs, the build is broken. There's 2 quick things that can be fixed:

After these 2 fixes the build fails because compilation errors in univocity-trader-binance-futures. See Maven log below, I'll continue explanation in next comment:

[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ univocity-trader-binance-futures ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 52 source files to /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/target/test-classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[11,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[13,15] method subscribeCandlestickEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.CandlestickInterval,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.CandlestickEvent>
  found:    java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.CandlestickInterval,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[15,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllMiniTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllMiniTicker.java:[12,15] method subscribeAllMiniTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<java.util.List<com.univocity.trader.exchange.binance.futures.model.event.SymbolMiniTickerEvent>>
  found:    (event)->{[...]t); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[12,15] method subscribeAllTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<java.util.List<com.univocity.trader.exchange.binance.futures.model.event.SymbolTickerEvent>>
  found:    (event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/trade/PostOrder.java:[19,45] method postOrder in interface com.univocity.trader.exchange.binance.futures.SyncRequestClient cannot be applied to given types;
  required: com.univocity.trader.exchange.binance.futures.model.trade.FuturesOrder,com.univocity.trader.exchange.binance.futures.model.enums.NewOrderRespType
  found:    java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.OrderSide,com.univocity.trader.exchange.binance.futures.model.enums.PositionSide,com.univocity.trader.exchange.binance.futures.model.enums.OrderType,com.univocity.trader.exchange.binance.futures.model.enums.TimeInForce,java.lang.String,java.lang.String,<nulltype>,<nulltype>,<nulltype>,<nulltype>,com.univocity.trader.exchange.binance.futures.model.enums.NewOrderRespType
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllLiquidationOrder.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllLiquidationOrder.java:[12,15] method subscribeAllLiquidationOrderEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.LiquidationOrderEvent>
  found:    (event)->{[...]t); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[12,15] method subscribeMarkPriceEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.MarkPriceEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/user/SubscribeUserData.java:[26,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/user/SubscribeUserData.java:[29,15] method subscribeUserDataEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.user.UserDataUpdateEvent>
  found:    java.lang.String,(event)->{[...]t); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[12,15] method subscribeSymbolLiquidationOrderEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.LiquidationOrderEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[12,15] method subscribeSymbolBookTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolBookTickerEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[12,15] method subscribeSymbolMiniTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolMiniTickerEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[12,15] method subscribeAggregateTradeEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.AggregateTradeEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[12,15] method subscribeDiffDepthEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.OrderBookEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[12,15] method subscribeSymbolTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolTickerEvent>
  found:    java.lang.String,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[12,15] method subscribeBookDepthEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: java.lang.String,java.lang.Integer,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.OrderBookEvent>
  found:    java.lang.String,int,(event)->{[...](); },<nulltype>
  reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[14,19] cannot find symbol
  symbol:   method unsubscribeAll()
  location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllBookTicker.java:[10,55] cannot find symbol
  symbol:   method create(java.lang.String,java.lang.String)
  location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllBookTicker.java:[12,15] method subscribeAllBookTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
  required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolBookTickerEvent>
  found:    (event)->{[...]t); },<nulltype>
  reason: actual and formal argument lists differ in length
[INFO] 39 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for univocity-trader 1.0.0-SNAPSHOT:
[INFO]
[INFO] univocity-trader ................................... SUCCESS [  1.220 s]
[INFO] univocity-trader-core .............................. SUCCESS [ 12.244 s]
[INFO] univocity-trader-binance ........................... SUCCESS [  1.301 s]
[INFO] univocity-trader-binance-futures ................... FAILURE [  1.700 s]
[INFO] univocity-trader-iqfeed ............................ SKIPPED
[INFO] univocity-trader-examples .......................... SKIPPED
[INFO] univocity-trader-chart ............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  16.629 s
[INFO] Finished at: 2021-03-06T22:23:58Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project univocity-trader-binance-futures: Compilation failure: Compilation failure:
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[11,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[13,15] method subscribeCandlestickEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.CandlestickInterval,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.CandlestickEvent>
[ERROR]   found:    java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.CandlestickInterval,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeCandlestick.java:[15,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllMiniTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllMiniTicker.java:[12,15] method subscribeAllMiniTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<java.util.List<com.univocity.trader.exchange.binance.futures.model.event.SymbolMiniTickerEvent>>
[ERROR]   found:    (event)->{[...]t); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[12,15] method subscribeAllTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<java.util.List<com.univocity.trader.exchange.binance.futures.model.event.SymbolTickerEvent>>
[ERROR]   found:    (event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllTicker.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/trade/PostOrder.java:[19,45] method postOrder in interface com.univocity.trader.exchange.binance.futures.SyncRequestClient cannot be applied to given types;
[ERROR]   required: com.univocity.trader.exchange.binance.futures.model.trade.FuturesOrder,com.univocity.trader.exchange.binance.futures.model.enums.NewOrderRespType
[ERROR]   found:    java.lang.String,com.univocity.trader.exchange.binance.futures.model.enums.OrderSide,com.univocity.trader.exchange.binance.futures.model.enums.PositionSide,com.univocity.trader.exchange.binance.futures.model.enums.OrderType,com.univocity.trader.exchange.binance.futures.model.enums.TimeInForce,java.lang.String,java.lang.String,<nulltype>,<nulltype>,<nulltype>,<nulltype>,com.univocity.trader.exchange.binance.futures.model.enums.NewOrderRespType
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllLiquidationOrder.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllLiquidationOrder.java:[12,15] method subscribeAllLiquidationOrderEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.LiquidationOrderEvent>
[ERROR]   found:    (event)->{[...]t); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[12,15] method subscribeMarkPriceEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.MarkPriceEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeMarkPrice.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/user/SubscribeUserData.java:[26,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/user/SubscribeUserData.java:[29,15] method subscribeUserDataEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.user.UserDataUpdateEvent>
[ERROR]   found:    java.lang.String,(event)->{[...]t); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[12,15] method subscribeSymbolLiquidationOrderEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.LiquidationOrderEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolLiquidationOrder.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[12,15] method subscribeSymbolBookTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolBookTickerEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolBookTicker.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[12,15] method subscribeSymbolMiniTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolMiniTickerEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolMiniTicker.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[12,15] method subscribeAggregateTradeEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.AggregateTradeEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAggregateTrade.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[12,15] method subscribeDiffDepthEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.OrderBookEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeDiffDepth.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[12,15] method subscribeSymbolTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolTickerEvent>
[ERROR]   found:    java.lang.String,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeSymbolTicker.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[12,15] method subscribeBookDepthEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: java.lang.String,java.lang.Integer,com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.OrderBookEvent>
[ERROR]   found:    java.lang.String,int,(event)->{[...](); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeBookDepth.java:[14,19] cannot find symbol
[ERROR]   symbol:   method unsubscribeAll()
[ERROR]   location: variable client of type com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllBookTicker.java:[10,55] cannot find symbol
[ERROR]   symbol:   method create(java.lang.String,java.lang.String)
[ERROR]   location: interface com.univocity.trader.exchange.binance.futures.SubscriptionClient
[ERROR] /home/drkarl/projects/univocity-trader/univocity-trader-binance-futures/src/test/java/com/univocity/trader/exchange/binance/futures/examples/websocket/SubscribeAllBookTicker.java:[12,15] method subscribeAllBookTickerEvent in interface com.univocity.trader.exchange.binance.futures.SubscriptionClient cannot be applied to given types;
[ERROR]   required: com.univocity.trader.exchange.binance.futures.BinanceFuturesApiCallback<com.univocity.trader.exchange.binance.futures.model.event.SymbolBookTickerEvent>
[ERROR]   found:    (event)->{[...]t); },<nulltype>
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :univocity-trader-binance-futures
drkarl commented 3 years ago

We see SubscribeCandleStick tries to use SubscriptionClient.create and unsubscribeAll but it can't find these methods. That's because they are commented, and you can see all the commented blocks in PR #116

If you uncomment the missing methods in SubscriptionClient they try to call BinanceApiInternalFactory.getInstance().createSubscriptionClient method but the last parameter they try to pass new SubscriptionOptions() but the method actually takes an AsyncHttpClient as the last method, so the signature has changed. The body of that method is also commented because it expects to receive the SubscriptionOptions and not theAsyncHttpClient.

Then it tries to create a new WebSocketStreamClientImpl but on the constructor it tries to pass as last argument a subscriptionOptions when it really expects an AsyncHttpClient. That class as well has commented method. And it goes on like that...

So in summary, it looks like it's something that is work in progress, like progress on some work started but it was not finished, there are some changes but there are still things to change so it doesn't compile, so it was commented, but it still didn't compile.

And these half done changes with commented blocks were introduced on PR #116.

I hope that helps.

You say you're able to build fine and I see your fork is 6 commits ahead, so maybe you completed that piece on your fork but forgot to submit a PR? if your fork is building fine, maybe you can submit a new PR to submit these 6 commits if they are completing the changes?

hlevel commented 3 years ago

You can delete the univocity-trader-binance-futures/src/test folder

jbax commented 3 years ago

I reverted the commit that removed test code and made the code compile again. They are not exactly tests but examples connecting to the api. That code was originally copied from https://github.com/Binance-docs/Binance_Futures_Java and it's probably outdated (the original in the repository remains unchanged by the API seems to have been updated).

I was able to build the entire project again if you try running the main method in these example classes you'll get exceptions - properties in the JSON response given by binance not mapped.

In any case, the build succeeds. I was trying to enable Travis CI but it doesn't recognize projects under my organization no matter what I do so I'll probably skip that for now.

Closing, thanks for your help!