search

uniVocity / univocity-trader

open-source trading framework for java, supports backtesting and live trading with exchanges
577 stars 140 forks source link

start of cli, and some refactoring #15

Closed teverett closed 4 years ago

teverett commented 4 years ago

started a generic cli which will expand into running market updater, simulator and live trader MarketHistoryUpdater class in core

jbax commented 4 years ago

Thanks, but don't create a new subproject to add one or two classes. Just leave everything in the univocity-trader project in a new package.

On Tue, 24 Dec. 2019, 8:29 am Tom Everett, notifications@github.com wrote:

started a generic cli which will expand into running market updater, simulator and live trader MarketHistoryUpdater class in core

You can view, comment on, or merge this pull request online at:

https://github.com/uniVocity/univocity-trader/pull/15 Commit Summary

  • start of cli, and some refactoring

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/uniVocity/univocity-trader/pull/15?email_source=notifications&email_token=ABWFQPVY4TDHPWQSJ4UN5TTQ2FQZPA5CNFSM4J6ZRLOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICNRNNQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWFQPXEYX3MGUX2JUQ3FWLQ2FQZPANCNFSM4J6ZRLOA .

teverett commented 4 years ago

The intent is to add additional classes down the road.

jbax commented 4 years ago

Then let's move them way later after these additional classes are there and it becomes big enough so it makes sense to create a new subproject. As it is there is no need for it.

On Tue, 24 Dec. 2019, 8:43 am Tom Everett, notifications@github.com wrote:

The intent is to add additional classes down the road.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uniVocity/univocity-trader/pull/15?email_source=notifications&email_token=ABWFQPXR3ORL545MCCME2GTQ2FSLJA5CNFSM4J6ZRLOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSIANY#issuecomment-568623159, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWFQPU6Z2WEZ3PJEM7HMPTQ2FSLJANCNFSM4J6ZRLOA .