search

uniVocity / univocity-trader

open-source trading framework for java, supports backtesting and live trading with exchanges
577 stars 140 forks source link

currencies #16

Closed teverett closed 4 years ago

teverett commented 4 years ago

Addition of a class which contains currencieas, both fiat and crypto. To be used later.

jbax commented 4 years ago

Not sure why we'd need this as the exchanges give the symbols available dynamically.

Should be OK if the intention is to display this in a UI later on. But use univocity-parsers ;-) for processing the CSV and expand our little monopoly

On Tue, 24 Dec. 2019, 8:40 am Tom Everett, notifications@github.com wrote:

Addition of a class which contains currencieas, both fiat and crypto. To be used later.

You can view, comment on, or merge this pull request online at:

https://github.com/uniVocity/univocity-trader/pull/16 Commit Summary

  • currencies

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/uniVocity/univocity-trader/pull/16?email_source=notifications&email_token=ABWFQPVAY24WUAS2VXQVAW3Q2FSBJA5CNFSM4J6ZS6B2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICNSH6Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWFQPRDB53CKQKFH2WKEATQ2FSBJANCNFSM4J6ZS6BQ .

teverett commented 4 years ago

I laughed. :)

jbax commented 4 years ago

Don't need to close this one unless you think there is no utility for it.

On Tue, 24 Dec. 2019, 8:53 am Tom Everett, notifications@github.com wrote:

Closed #16 https://github.com/uniVocity/univocity-trader/pull/16.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uniVocity/univocity-trader/pull/16?email_source=notifications&email_token=ABWFQPRD2PNYJ2EWQ5IT6XLQ2FTQRA5CNFSM4J6ZS6B2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVU2VCJQ#event-2905952550, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWFQPR367TJ3M7SJHMBT4LQ2FTQRANCNFSM4J6ZS6BQ .

jbax commented 4 years ago

Reopening as the changes are mostly OK. I'll update to use univocity-parsers