search

uniVocity / univocity-trader

open-source trading framework for java, supports backtesting and live trading with exchanges
577 stars 140 forks source link

Adding IQFeed Interface, builder for Candle in univocity-trader-core #23

Closed jecker7 closed 4 years ago

jecker7 commented 4 years ago

Interface to retrieve historical prices from IQFeed w/ websocket connection and API-specific requests

jbax commented 4 years ago

Thanks a lot for your contribution!! I'll try merge it all today. Do you mind writing a quick usage guide in a README.md to the root of this univocity-trader-IQFeed subproject?

jecker7 commented 4 years ago

Sure thing, will be making a lot of changes in next few days.

jbax commented 4 years ago

Almost all changes merged manually, thanks a lot. I made a few adjustments and did not introduce the candle builder as it's not used anywhere.

Creating a simulator or live trader is exactly as you'd do with Binance (see updated tutorial for reference):

    IQFeed.Simulator simulator = IQFeed.simulator();
    Account account = simulator.configure().account();

    simulator.run();

Thanks again!

jecker7 commented 4 years ago

Is there any way I can still be added to contributor list for my contribution? Or does manual merge negate this?

jbax commented 4 years ago

Yes the commit I did won't have your user associated with them. I didn't realize that, sorry.

The only solution I can think to make you appear in the "blame" list on github is to delete the iqfeed subproject. Then you can submit a PR that reverts my commit and puts it all back. Dirty but will work.

Alternatively you can submit a simple PR which adds the javadoc tag @author plus your name or email to the files in the iqfeed subproject.

Feel free to also add yourself to the section of the pom.xml as well.

I changed the repository rules to only allow squashed PRs (all changes in a PR come as a single commit) because merging all individual changes was being time consuming and painful. This will prevent having to manually copy changes from large PRs.

On Tue, 7 Jan. 2020, 5:33 am jecker7, notifications@github.com wrote:

Is there any way I can still be added to contributor list for my contribution? Or does manual merge negate this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/uniVocity/univocity-trader/pull/23?email_source=notifications&email_token=ABWFQPU3SLSVK3YPWDLN5LDQ4OWTRA5CNFSM4KCZ43MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHASWY#issuecomment-571345243, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWFQPVUVXAPPNZWBRO67VDQ4OWTRANCNFSM4KCZ43MA .

jecker7 commented 4 years ago

Alright, I'll delete the module and make another squashed commit for the whole project after some additional work and more complete testing, needs more changes anyway. Thanks for the tips.