With Commit f6f11a2, I attempted to fix a bug in how signal-dcc parameters are calculated. I based the bugfix on the code for dcc points. However, I made a mistake doing that.
On line 256 in bidib_highlevel_setter, the .value member should be left-shifted by 5, note ORed with a 1 that was left-shifted by 5. Compare the following:
With Commit f6f11a2, I attempted to fix a bug in how signal-dcc parameters are calculated. I based the bugfix on the code for dcc points. However, I made a mistake doing that.
On line 256 in bidib_highlevel_setter, the .value member should be left-shifted by 5, note ORed with a 1 that was left-shifted by 5. Compare the following:
Current buggy signals dcc assignment:
Correct points dcc assignment:
The necessary action to be taken is obvious.