Closed BLuedtke closed 11 months ago
The failing build seems to be a regression in the area of config_get_array_string_value
, specifically if it's about main_segments
. Will investigate.
last_scalar in parser_util was freed a bit too early, causing the parser to act slightly differently in some of the callbacks. Tests now run fine on my machine.
Suggested tests:
What does "physical test cases" refer to? There are none for cli, only for bidib. The test script that uses the python client isnt any better than me testing with the python client directly in this case.
Anyway, I just had a long test session. Tested all web pages (normal + game) and the full python client. test notes 2023-08-04.md
Only one issue was querying the reverser state. need to check that in more detail and compare against other branches.
Interesting: I think I found a much simpler reason for why we had trains going the wrong way, but I need to do some more checks to confirm...
Alright, I can't get the reverser state if no train is sitting on the Kehrschleife. But this is the same as on the master branch. If a train is on there, I get the info as intended. So that works, and concludes my testing.
Should probably make physical test cases based on sample_test_script.sh
for switching points and signals, and running a train.
The reverser query behaviour doesn't sound normal. Are you able to get the monitor to print "on" and "off" for the reverser state?
Is BiDiB Wizard able to read the reverser state?
I will open a new issue for the reverser problem, as it happens on the master branch too.
The other problem I found is that automatic route driving get's the direction wrong in a very specific situation with the Kehrschleife. Maybe the two problem are interlinked.
This PR addresses 2 areas:
Open TODOs that should be discussed/resolved/moved before merging this PR:
Furthermore, whilst some manual testing has been performed, more rigorous use/testing is needed.
I also suggest to squash commits upon merging, as it's, well, quite a lot of experimental small ones.