search

uniba-swt / swtbahn-cli

A client-server command line interface for the SWTbahn.
GNU General Public License v3.0
7 stars 3 forks source link

Added general compability for tableGenerator (SWTbahn-Game) #132

Open noriakisana opened 7 months ago

noriakisana commented 7 months ago

Changed the tableGenerator to automatically generate all configuration files which are needed for the driver-game, as soon a mappingFile is existing.

eyip002 commented 7 months ago

Have you tested that the Game still works? I don't think the Game works anymore. How does the Game know which platform it is connected to, so that it uses the correct flag mappings?

The generated destinations-swtbahn-full.json includes the blacklisted routes. You should restore the previous blacklist.txt file and rename it to blacklist-swtbahn-full.txt and update your Python script accordingly.

noriakisana commented 7 months ago

Currently the platforms have to been set manual. For an automatic solution the issue https://github.com/uniba-swt/swtbahn-cli/issues/131 have to be fixed.

noriakisana commented 7 months ago

blacklist feature is now added

eyip002 commented 7 months ago

Are you also testing that the initial loading of the game script still works?

noriakisana commented 7 months ago

shouldnt work currently cause the dependency selection is broken (need who am I API).

eyip002 commented 7 months ago

For pull requests to be merged, the software needs to run correctly. We can't leave the software in a broken state. You can create a getPlatformName function in the game script that returns the name of the platform as a string. The return value can be hardcoded while #131 is being worked on.

function getPlatformName() {
  return "swtbahn-full";
}

Use this function in the initialise function to select the correct destinations and mappings to use.

noriakisana commented 7 months ago

need to be verified next week on hardware

noriakisana commented 5 months ago

works.