uniba-swt / swtbahn-cli

A client-server command line interface for the SWTbahn.
GNU General Public License v3.0
7 stars 3 forks source link

Verification on Engine Upload shall be integrated and configurable via Admin Client #62

Closed BLuedtke closed 1 year ago

BLuedtke commented 2 years ago

(Feature Request)

The experimental feature for verification of train engines upon upload shall be integrated into the main branch. With additional functionality: An Admin shall be able to enable or disable whether engines are verified upon upload. An Admin shall be able to do so via a web-interface akin to those existing for drivers and controllers. Furthermore, this shall be possible via the Python client as well.

I'll work on implementing this functionality. I'll do so on the verify_engine_models branch.

BLuedtke commented 2 years ago

Ran some user-tests on the changes in the verify_engine_models branch. Small adjustments were needed, but generally works now. Two issues remaining that I saw:

eyip002 commented 2 years ago

What if the verification section of the Admin page is initially a Get Verification Settings button that only reveals the verification settings if the verification server is running?

BLuedtke commented 2 years ago

That would be a valid workaround. Though a single small extra http-get for a page load is not that bad either, so we could leave it as-is. Just need to update/remove the 'running' check in the handler for that get.