Clamp ply - Githubissues

unibas-gravis / scalismo-faces

Scalable Image Analysis and Shape Modelling: Module to work with 2d images, with a focus on face images

Apache License 2.0

118 stars 27 forks source link

Clamp ply #111

Closed BernhardEgger closed 6 years ago

BernhardEgger commented 6 years ago

Solves Issue #110 Does not write anymore invalid RGB values out

Andreas-Forster commented 6 years ago

Thank you for the pull-request. I think this really solves the issue you are addressing. As we use uchar to write the colors to the file the colors should be clamped. One should just keep in mind that then the meshes do no longer correspond to the model instance.

BernhardEgger commented 6 years ago

The meshes anyway did not correspond to the model instance:

since the model instance is a color in Double
so far negative values were written in a very wrong way which also lead to meshes not matching to the model instances. Actually now the meshes match the model instances better since -32 gets 0 and not something above 0 :)