search

unibas-gravis / scalismo-faces

Scalable Image Analysis and Shape Modelling: Module to work with 2d images, with a focus on face images
Apache License 2.0
118 stars 27 forks source link

Replace spray with ujson #138

Closed Andreas-Forster closed 1 year ago

Andreas-Forster commented 1 year ago

This PR replaces spray json with ujson as dependency.

While the tests are reordered a bit, they are covering the same functionality as before and they pass.

Andreas-Forster commented 1 year ago

I somehow did not like the ...JSON... in CamelCase :-), but reverted it now for clarity.

I renamed the package mappers into formats, then it's intention is more clear. The most important class is the RenderParameterJSONFormats with most mappers for the default serialization format.

The other classes in there represent the former parameters and serialization structures better. I also found it more readable to define a case class representing the old serialization structure and serialize it with the marcoRW. Of course the other option with just a readwriter...bimap .... might also a possible option. I just hope nobody needs to dig into it anymore. Maybe deprecating some formats would also be an option in the future.

marcelluethi commented 1 year ago

perfect. Thanks a lot. Then I think it is good to merge.