search

uniberg / kbn_sankey_vis

Sankey diagram for Kibana visualize.
Apache License 2.0
29 stars 11 forks source link

[sankey] Fix for the graph bug after updating the buckets #8

Closed ch-bas closed 5 years ago

ch-bas commented 5 years ago

Some side effects were noticed after the integration of the last auto resize feature. The first one is relative about a performance issue after each resize operation. The second one is detected when you change the input of the buckets and you want to perform a new resize action.

kaihil commented 5 years ago

This works and looks good (despite my two comments) 👍

P.S. Next time, please try to fulfill our conventions for git commit messages. It should be in imperative form and explain the reader what you did. e.g. [sankey] Fix displaying the graph while resizing. In case the story you want to tell is too long for a single line, you may also use multiple lines for explaining a commit. e.g.

[sankey] Fix displaying the graph while resizing

* bla 1
* bla 2