Closed stefan-k closed 3 years ago
I'm fine with both options and I'm happy to provide an updated PR.
@olifre: What do you think?
I also think undef
feels more natural, in fact, since we already have Optional
for the class parameter, undef
should ideally have a meaning ;-).
Thanks for the feedback! I changed it accordingly. I needed to change the default value of auth_obs
from gsi
to undef
, which may be a breaking change.
I can certainly squash the commits, but then I have to force-push and the history will be lost. Is there a reason why you prefer manual squashing over Github's Squash and merge
functionality?
We prefer having a linear history with the intermediate steps from the drafting stage cleaned up. We also think that the PR author is the best person to write a concise summary of the intention and the contents of the PR.
First of all thanks for this module! In our setup, the overlay batch system runs locally, therefore (if I understand this correctly) we do not require authentication via
auth_obs
. In this PR I've added anone
switch which allows for bypassing the related section ininstall.pp
. I don't know if this has other implications that I'm not aware of, as I currently can't test it because I first need to solve other unrelated problems ;) It would be great if you could provide feedback to this PR. Feel free to reject it if it doesn't fit into the module.