search

unibonn / puppet-cobald

Puppet module for COBalD/TARDIS based opportunistic resource management
Apache License 2.0
1 stars 7 forks source link

Allow missing authentication method for overlay batch system #1

Closed stefan-k closed 3 years ago

stefan-k commented 3 years ago

First of all thanks for this module! In our setup, the overlay batch system runs locally, therefore (if I understand this correctly) we do not require authentication via auth_obs. In this PR I've added a none switch which allows for bypassing the related section in install.pp. I don't know if this has other implications that I'm not aware of, as I currently can't test it because I first need to solve other unrelated problems ;) It would be great if you could provide feedback to this PR. Feel free to reject it if it doesn't fit into the module.

stefan-k commented 3 years ago

I'm fine with both options and I'm happy to provide an updated PR.

olifre commented 3 years ago

@olifre: What do you think?

I also think undef feels more natural, in fact, since we already have Optional for the class parameter, undef should ideally have a meaning ;-).

stefan-k commented 3 years ago

Thanks for the feedback! I changed it accordingly. I needed to change the default value of auth_obs from gsi to undef, which may be a breaking change.

stefan-k commented 3 years ago

I can certainly squash the commits, but then I have to force-push and the history will be lost. Is there a reason why you prefer manual squashing over Github's Squash and merge functionality?

wiene commented 3 years ago

We prefer having a linear history with the intermediate steps from the drafting stage cleaned up. We also think that the PR author is the best person to write a concise summary of the intention and the contents of the PR.