search

unibonn / puppet-cobald

Puppet module for COBalD/TARDIS based opportunistic resource management
Apache License 2.0
1 stars 7 forks source link

Allow specifying Git URL and/or branch #4

Closed stefan-k closed 3 years ago

stefan-k commented 3 years ago

Currently, indicating master for $cobald_version or $tardis_version leads to COBalD/TARDIS being installed from the master branch of the official repositories. It would be useful to allow setting both URL and branch by the user. Technically this is trivial to implement, but before I make the changes and issue a PR, I'd like to ask you for your opinions on this.

The main problem I see is that $cobald_version and $tardis_version are used to both indicate either the version on PyPI or the master branch. Allowing this variable to also take other branch names than master would make it impossible to distinguish whether the user wants a branch on Git or a PyPI version.

Therefore I suggest the additional arguments $cobald_provider and $tardis_provider, which can be either git or PyPI. The variables $cobald_version and $tardis_version can then be either a PyPI version or a git branch name, depending on the chosen provider.

Allowing for user-chosen Git URLs is then also trivial to solve by adding $cobald_git_url and $tardis_git_url arguments which default to the official repository if not provided.

Is there interest in such a feature? What are your opinions on the suggested approach?

stefan-k commented 3 years ago

I went ahead and implemented my idea in #5 .