search

unibonn / puppet-cobald

Puppet module for COBalD/TARDIS based opportunistic resource management
Apache License 2.0
1 stars 7 forks source link

Allow specifying Git URL and/or Git branch #5

Closed stefan-k closed 3 years ago

stefan-k commented 3 years ago

See #4 .

stefan-k commented 3 years ago

Thanks a lot for your comments and suggestions! I tried to address them all. I can squash the commits now for the next review or right before merging, whatever you prefer.

stefan-k commented 3 years ago

Thanks again! I hope this is how you had it in mind.

olifre commented 3 years ago

Thanks again! I hope this is how you had it in mind.

Indeed, and I realize only in the updated version that in fact there was a difference between the Git and PyPI based resources :wink:. So for sure the new compressed version is more readable :+1: . @wiene Do you spot anything else? It LGTM so if you don't spot anything, it can be squashed and :rocket: .