[WIP] Add Stylelint - Githubissues

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns

Other

121 stars 18 forks source link

Closed backflip closed 6 years ago

backflip commented 7 years ago

[ ] Document config (I basically started with the defaults and adapted them wherever I thought our somewhat implicit guidelines would expect something different)
[ ] Fix watcher (it won't run as a dependency of css when the file watcher is triggering the task function directly: https://github.com/unic/estatico/blob/develop/gulp/watch.js#L41). This currently fails for JS linting, too, I assume.
[x] Use default notification handling on errors (it currently doesn't trigger a OS X notification, e.g.)
[ ] Test in IDEs
[ ] Discuss!!

lbsonley commented 7 years ago

Stylelint is not a very effective tool in Webstorm. Errors are not displayed in a usable way.

screen shot 2017-02-10 at 16 33 17

backflip commented 7 years ago

Let's wait until WebStorm displays errors in a more meaningful way.

orioltf commented 7 years ago

Could we re-check the status from this PR? We need to go forward with the BEM implementation and I guess Stylelint could help with it, right? I see some options with this according to https://www.smashingmagazine.com/2016/05/stylelint-the-style-sheet-linter-weve-always-wanted/, but googling around I ca see a postcss linter and a Stylint plugin that incorporates the previous.

There is even BEMLint that checks HTML files too. Would it work with hbs files? (Sounds like a challenge to take! 😜

@lbsonley Would you like / Would you have time to invest some in it? @backflip How would you see this?

lbsonley commented 7 years ago

@orioltf I will take a look a this again over the weekend.

backflip commented 6 years ago