search

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

Update to jQuery 3.x #21

Closed caillou closed 6 years ago

caillou commented 7 years ago

Is there a reason, we still use jQuery 2.x?

jQuery 3.x uses rAF for it's .animate() method, which in my opinion is enough of a feature to use it.

backflip commented 7 years ago

PR welcome! Apparently, there are some breaking changes regarding how we deal with attributes / properties, but since we don't have too much JS in the boilerplate, it should be feasible.

@marbor3, any inputs here?

marbor3 commented 7 years ago

Hey!

Sorry for the delay but I had a terrible time management issues lately ...

Never the less: https://github.com/unic/estatico/pull/45

We've been using this on a project for some time now - and like you said @backflip , there's not too much jQuery based code there so it looks like we needed just those two changes :)

christiansany commented 6 years ago

@backflip PR was merged, ticket can be closed :)

orioltf commented 6 years ago

Thanks!