search

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

Fix tests #22

Closed caillou closed 7 years ago

caillou commented 7 years ago

Tests are broken in master.

/Users/caillou/Projects/estatico/node_modules/gulp-raster/lib/converter.js:27
            .done(function (img) {
             ^

TypeError: phantomProcess.then(...).done is not a function
caillou commented 7 years ago

OK, seems like installing the dependencies with npm rather than yarn fixes that issue. Sorry about that.

This being said, ideally we should move forward with with our time and keep an evergreen repository.

backflip commented 7 years ago

Yarn will not properly resolve git commits in dependencies. We'll have to work around this with tags.

backflip commented 7 years ago

What do you mean by "evergreen repository"?

caillou commented 7 years ago

Things kept green ;) E.g. using https://greenkeeper.io/

Staying up to date with dependencies.

backflip commented 7 years ago

Ah, I see. However, it's not a production environment, so we have way less interest in spending a lot of time keeping everything up-to-date (compared to an environment where it would be a security risk not to do it). And this specific use-case would have still failed with Greenkeeper since it's a Yarn issue.

But we'll definitely give this some more thought, thanks for the pointer!