search

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

fixed imagemagick usage #30

Closed swey closed 7 years ago

swey commented 7 years ago

Without that fix ImageMagick is not working for us (same problem with the old estatico version): Could not execute GraphicsMagick/ImageMagick: gm "identify" "-ping" "-format" "%wx%h" "/Users/.../source/demo/modules/imageversions/media/george.jpg" this most likely means the gm/convert binaries can't be found Error: Could not execute GraphicsMagick/ImageMagick: gm "identify" "-ping" "-format" "%wx%h" "/Users/.../source/demo/modules/imageversions/media/george.jpg" this most likely means the gm/convert binaries can't be found

backflip commented 7 years ago

I just wanted to respond that we had severe quality issues with ImageMagick when generating PNGs from SVGs. However, we don't seem to use it for that purpose anymore. :) Did you ever see any quality differences when resizing images with media:imageversions?

I agree that the current situation is not ideal, we only mention the dependency in https://github.com/unic/estatico/blob/develop/docs/Setup_and_Usage.md#dependencies but don't really provide useful feedback when it's missing.

So I'd either go for a detection and useful error log or - if the quality is really not an issue in this use-case - go for ImageMagick. Or does anyone know whether we could easily fall back to ImageMagick if GraphicsMagick is missing?

backflip commented 7 years ago

Works fine for me locally, however, the resulting demo images are 50% bigger than with GraphicsMagick.

Does anyone use this task for images going into production (where size would matter)?

backflip commented 7 years ago

Moved to https://github.com/unic/estatico/pull/43, using detection.