search

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

[Bugfix] Fix for Mediaqueries helper #81

Closed Wymowny closed 6 years ago

Wymowny commented 7 years ago

Missing parameter added to mediaqueries helper

orioltf commented 6 years ago

Hi Marcin! Thanks for this PR :). Have you thought on adding the event at the end of the current list of arguments?

I agree that having the event at the beginning feels more natural to common sense and normal implementations. I see as well, the for keeping backwards compatibility it would be better the opposite. How do you think?

Wymowny commented 6 years ago

Hello @orioltf, sorry for that, but I needed to create new branch since I somehow broke my previous repo. Anyway I fixed above issue and order for arguments is now correct:

https://github.com/unic/estatico/pull/91