search

unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

Remove unused `_helper` method #9

Closed caillou closed 7 years ago

caillou commented 7 years ago

It seems like the _helper method has no reason to be. Instead we can just call SuperClass.apply(this, {}).

backflip commented 7 years ago

Thanks for the input! We are currently preparing an ES2015 version and will push it in the next days, so this will most probably be superseded by a "real" Class approach. I will keep you posted.

caillou commented 7 years ago

@backflip ok. Just to be sure: this is some legacy code, right? Or is there a reason for the _helper()? I plan to do a refactoring on our codebase ;)

backflip commented 7 years ago

There might have been a reason at one point. Though I can't really think of one right now.

caillou commented 7 years ago

@backflip could you either merge or close the PR?