search

unicef-polymer / etools-searchable-multiselection-menu

Apache License 2.0
2 stars 3 forks source link

Fix multi select not setting selected values when changed externally #102

Closed marko911 closed 6 years ago

marko911 commented 7 years ago

The observer looks for selected values to have a length otherwise it wont fire, so when the menu's selected items get cleared programmatically by a parent element the menu doesn't re-set the actual values.

daniel-tabarcea commented 7 years ago

Is this the final version of the modification? And what's the use case for it? Setting what should be an array to null is a bit confusing to me

adi130987 commented 7 years ago

@marko911 are you using clearValues method, is it really needed? ... @daniel-tabarcea has made a fix for null selectedValues (#104).

adi130987 commented 6 years ago

closing... should be fixed by #104