unicef-polymer / etools-searchable-multiselection-menu

Apache License 2.0
2 stars 3 forks source link

Adding possibility to edit paper-input-container-label styles #80

Closed gpg90 closed 7 years ago

gpg90 commented 7 years ago

We need to possibility to edit inputs label styles in another module, so we are defining esmm-input-container-label mixin to achieve that. (There's a --esmm-readonly-input-container-label mixin, but it applies only in readonly state and for label in search dropdown.)

adi130987 commented 7 years ago

See if you can use --paper-input-container-label for this without this PR change. If you cannot then let me know and I will merge your PR.

etools-searchable-multiselection-menu it's deprecated starting with v2.1.0, we will not maintain it anymore, we use instead etools-single-selection-menu and etools-multi-selection-menu.

--esmm-readonly-* most probably are gonna be deleted in the near future because you can use paper-input-container vars and mixins to style the element.

gpg90 commented 7 years ago

Yeah, thanks. Indeed with the latest changes we should be good with using --paper-input-container-label.

So, closing this PR - no merge is needed.