search

unicef / drone-4sdgtoolkit

Toolkit of drones-for-public-good resources including text, image, video and audio content, and open-source software, code, libraries, and training datasets.
https://unicef.github.io/drone-4sdgtoolkit/
Creative Commons Attribution Share Alike 4.0 International
8 stars 4 forks source link

Internal images missing in generated HTML #26

Closed jwflory closed 2 years ago

jwflory commented 2 years ago

Summary

Some images use invalid internal links, and causes the CI pipeline to break

Background

A few pages are using internal images with incorrect links. When the Drone Toolkit is generated before deployment, the site generator checks for the files but it is unable to find them. This causes the CI pipeline to fail, and new changes are not published to the live site.

Details

The errors caught by HTML-Proofer are listed below:

$ htmlproofer ./public --allow-hash-href --alt-ignore --check-html --directory-index-file index.html \
    --disable-external --empty-alt-ignore --extension '.html' --http-status-ignore '0,999' --timeframe '6w' \
    --url-ignore '/drone-4sdgtoolkit/' |& grep "internal image"

- ./public/guides/drone-4-supply/index.html
  *  internal image /static/guides/dronesupplychain001.jpg does not exist (line 366)
- ./public/guides/humanitarian-drone-mission/index.html
  *  internal image /static/guides/humanitarianguidestep001.jpg does not exist (line 419)
  *  internal image /static/guides/humanitarianguidestep002.jpg does not exist (line 421)
  *  internal image /static/guides/humanitarianguidestep003.jpg does not exist (line 423)
  *  internal image /static/guides/humanitarianguidestep004.jpg does not exist (line 425)
  *  internal image /static/images/unicefinnovlogo.png does not exist (line 365)
- ./public/guides/satellites-vs-drones/index.html
  *  internal image /static/guides/satvdronesd4g001.png does not exist (line 551)
  *  internal image /static/guides/satvdronesd4g002.jpg does not exist (line 568)
  *  internal image /static/guides/satvdronesd4g003.jpg does not exist (line 595)
  *  internal image /static/guides/satvdronesd4g004.jpg does not exist (line 607)
  *  internal image /static/guides/satvdronesd4g005.jpg does not exist (line 614)
  *  internal image /static/guides/satvdronesd4g006.jpg does not exist (line 616)
  *  internal image /static/guides/satvdronesd4g007.jpg does not exist (line 622)
  *  internal image /static/guides/satvdronesd4g008.jpg does not exist (line 628)
  *  internal image /static/images/unicefinnovlogo.png does not exist (line 365)
- ./public/learning/index.html
  *  internal image /static/learning/adda.jpg does not exist (line 281)
- ./public/software/index.html
  *  internal image /static/software/monitoring.jpg does not exist (line 280)
  *  internal image /static/software/software001.jpg does not exist (line 294)

Eventually, these errors will become visible in the logs too, once CircleCI-Public/hugo-orb#47 is merged and released.

Outcome

New updates are deployed to the live site

jwflory commented 2 years ago

@enonied4g and I worked through this on a call today. All the broken URLs are fixed. Closing. 🎬