unicef / etools-issues

0 stars 2 forks source link

Links in PD/SSFA ToR overview #231

Open mpawlowski85 opened 7 years ago

mpawlowski85 commented 7 years ago

See screenshot for reference Link 1 - should take to to the Partner Details tab of that partner. Link 2 - Should take me to the particular trip (currently it takes me to the partner details).

mpawlowski85 commented 7 years ago

upload_3_27_2017_at_10_36_27_am

daniel-tabarcea commented 7 years ago

I've made a fix the first link, but where are the monitoring visits supposed to point to?

mpawlowski85 commented 7 years ago

Link 2 takes you to the particular monitoring visit in the TRIP module

daniel-tabarcea commented 7 years ago

What url should that be? I've only worked on PMP so far, i don't know where to link it to

mpawlowski85 commented 7 years ago

This is an example: https://etools.unicef.org/t2f/edit-travel/8

but I think that this needs to be confirmed by @robertavram

daniel-tabarcea commented 7 years ago

An api update is needed before i can add that link. @ntrncic Can you add the id of the travel activity to the api response so i can add it to the url? We're getting our monitoring visits data from /api/t2f/travels/activities//

ntrncic commented 7 years ago

@simon-the-sloth can we return the travel id for endpoint https://etools-staging.unicef.org/api/t2f/travels/activities/13/

simon-the-sloth commented 7 years ago

@ntrncic Sure.

adi130987 commented 7 years ago

@ntrncic, @simon-the-sloth, @robertavram any update on this?

robertavram commented 7 years ago

I added partner_id to the intervention details, for link 1 you can format /pmp/partners/[intervention.partner_id]/details

for link 2.. each travel record comes with atrip_id, you can format the link: /t2f/edit-travel/[trip_id] @daniel-tabarcea @adi130987

janpanchalingam1 commented 7 years ago

Passed testing