unicef / etools-issues

0 stars 2 forks source link

PD/SSFA: "FR Validation - Amounts and Dates" - Message ALM 229 #682

Open mpawlowski85 opened 7 years ago

mpawlowski85 commented 7 years ago

PD/SSFA: "FR Validation - Amounts and Dates" - Message reads, "FR start date, FR end date are not the same as PD/SSFA start date, end date". The amount should have been included in the message.

Browser: Chrome Workspace: Jordan

PCA: JOR/PCA2017181/PD2017148 (Start Date: 6 Sep 2017, End Date: 7 Sep 2017, UNICEF Cash: 2.00) FR No: 0000000027 (Start Date: 2017-09-01, End Date: 2017-09-06, Total Amt: 20.00)

Message should read, "FR start date, FR end date and FR amount are not the same as PD/SSFA start date, end date and UNICEF cash (USD)"

adi130987 commented 7 years ago

@daniel-tabarcea please take a look at this issue.

daniel-tabarcea commented 7 years ago

Can't reproduce it. The PCA you pointed out doesn't have any erros, and i couldn't find another one that has the issue described. Can you retest it after the next deploy to staging?

mpawlowski85 commented 7 years ago

Hi @daniel-tabarcea So the issue would only occur at intervention level (not PCA). The validation compares 3 things:

If any of these values are not the same, the message should reflect it. e..g i only start date and UNCIEF cash are not matching, then the message should only state: The Start Date, Unicef Cash Contribution is not the same as the FR Start Date, FR Amount. Do you want to continue?

In the described scenario, all 3 values did not match up, but the message only shows talks about 2 values.

I just managed to reproduce it, so it is still an issue: image

adi130987 commented 7 years ago

@mpawlowski85 we have a fix for this, it will de deployed today.

mpawlowski85 commented 6 years ago

Passed in staging