Open mpawlowski85 opened 6 years ago
@ntrncic the frs_details we're getting from the interventions endpoint has four values in it:
actual_amt, intervention_amt, outstanding_amt, total_amt.
Right now FR Amount $
is set to show total_amt
and it looks like it should be showing intervention_amt
. Can you confirm that's what we should be displaying on the front-end?
@daniel-tabarcea yes it should be intervention_amt
the in-line item was corrected, however the total is still incorrect. issue #780 was raised to track the other issue. this issue is passed in staging
@mpawlowski85 @ntrncic what happens with the FRs consistency validation tooltip? Right now the total_frs_amt
and the unicef_cash
values are used to show the tooltip. Do we use the right properties for this check? With the change from total_frs_amt
to total_intervention_amt
the tooltip show condition is not valid anymore and it should be removed.
@adi130987 please leave the validation tooltip. I realize that it seems contradictory because you validate against one amount and display the tooltip next to another. However, because of the fact that all of our PDs are in local currencies, but the accounting system is in USD and the XE rates change every month, we must leave it like this - the validation will not work any other way.
@mpawlowski85 ok. I just wanted to make sure we validate the FRs consistency using the right amounts.
The FR amount on the Implementation Status table in the PD Overview is the incorrect amount. Currently, it shows the FR Overall Amount, while it should show the Current FR Amount.