jtoaha
commented
3 years ago I actually did do a git pull on Sunday before I started working on it, so I could get the changes Ha made. Just saw your suggestions. Understood, will do so and see what happens! Thank you!
On Sep 30, 2020, at 9:16 AM, Nathan Baleeta notifications@github.com wrote:
@nathanbaleeta requested changes on this pull request.
At the moment I'm unable to merge your changes into the develop branch, there seems to be some merge conflicts.
I noticed the branch you were working on that you raised a pull request for was behind branch responsive-footer which was successfully merged about 5 days ago. I suggest you clone the repo a fresh and create a new branch and copy your changes then push the code again to github.
In future you may wish to perform git pull right before you git push to make sure your changes are not conflicting with the default origin.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi Nathan. This is a new pull request. I took a different approach to the code this time. The code for the most part transitions smoothly between the different breakpoints (with no need to refresh). And I worked on developing mobile-first oriented CSS and tried to not to incorporate any thing that would cause end user to rely too much on Javascript. For that reason, I did not import any libraries to do this code, as I did in my first round. However, I did include a link in the index.js file to Material Design icons and a Google front from Google. Also I ran 'yarn run build' and it compiled without any failures, at least so far! Thank you.